[PATCH] mfd: ABX500_CORE should depend on ARCH_U8500

[PATCH] mfd: ABX500_CORE should depend on ARCH_U8500

[Geert Uytterhoeven]

The ST-Ericsson ABX500 Mixed Signal IC family chips are only present on
ST-Ericsson U8500 Series platforms.  Hence add a dependency on
ARCH_U8500, to prevent asking the user about this driver when
configuring a kernel without U8500 support.

Also, merely enabling CONFIG_COMPILE_TEST should not enable additional
code, and thus should not enable this driver by default.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/mfd/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 21a131d4e7bb9eca..d07e8cf9328612c5 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1235,7 +1235,8 @@ config MFD_SC27XX_PMIC
 
 config ABX500_CORE
 	bool "ST-Ericsson ABX500 Mixed Signal Circuit register functions"
-	default y if ARCH_U8500 || COMPILE_TEST
+	depends on ARCH_U8500 || COMPILE_TEST
+	default y if ARCH_U8500
 	help
 	  Say yes here if you have the ABX500 Mixed Signal IC family
 	  chips. This core driver expose register access functions.
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] mfd: ABX500_CORE should depend on ARCH_U8500

[Linus Walleij]

On Tue, Mar 16, 2021 at 2:37 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:

> The ST-Ericsson ABX500 Mixed Signal IC family chips are only present on
> ST-Ericsson U8500 Series platforms.  Hence add a dependency on
> ARCH_U8500, to prevent asking the user about this driver when
> configuring a kernel without U8500 support.
>
> Also, merely enabling CONFIG_COMPILE_TEST should not enable additional
> code, and thus should not enable this driver by default.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Very nice. Good catch!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] mfd: ABX500_CORE should depend on ARCH_U8500

[Lee Jones]

On Tue, 16 Mar 2021, Geert Uytterhoeven wrote:

> The ST-Ericsson ABX500 Mixed Signal IC family chips are only present on
> ST-Ericsson U8500 Series platforms.  Hence add a dependency on
> ARCH_U8500, to prevent asking the user about this driver when
> configuring a kernel without U8500 support.
> 
> Also, merely enabling CONFIG_COMPILE_TEST should not enable additional
> code, and thus should not enable this driver by default.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/mfd/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel