From: Sudeep Holla <sudeep.holla@arm.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: vexpress: spc: fix uniprocessor initialization
Date: Fri, 26 Mar 2021 13:41:31 +0000 [thread overview]
Message-ID: <20210326134131.bftspszcwixrkomt@bogus> (raw)
In-Reply-To: <20210323125649.1930186-1-arnd@kernel.org>
Hi Arnd,
Sorry for the delay
On Tue, Mar 23, 2021 at 01:56:38PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When CONFIG_SMP is disabled, topology_physical_package_id()
> returns -1 and gcc notices undefined behavior:
>
> arch/arm/mach-versatile/spc.c: In function 've_spc_clk_init':
> arch/arm/mach-versatile/spc.c:583:21: error: array subscript -1 is below array bounds of 'bool[2]' {aka '_Bool[2]'} [-Werror=array-bounds]
> 583 | if (init_opp_table[cluster])
> | ~~~~~~~~~~~~~~^~~~~~~~~
> arch/arm/mach-versatile/spc.c:556:7: note: while referencing 'init_opp_table'
> 556 | bool init_opp_table[MAX_CLUSTERS] = { false };
> | ^~~~~~~~~~~~~~
>
> It's not clear to me what the correct behavior should be, but
> it seems safe to just not continue with the initialization.
>
I don't have any other patches for vexpress platform or driver support.
Can you apply this directly ? Assuming that,
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-03-26 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 12:56 [PATCH] ARM: vexpress: spc: fix uniprocessor initialization Arnd Bergmann
2021-03-26 13:41 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210326134131.bftspszcwixrkomt@bogus \
--to=sudeep.holla@arm.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox