From: Cristian Marussi <cristian.marussi@arm.com>
To: Wan Jiabing <wanjiabing@vivo.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kael_w@yeah.net
Subject: Re: [PATCH] firmware: arm_scmi: Remove repeated struct declaration
Date: Tue, 27 Apr 2021 07:36:04 +0100 [thread overview]
Message-ID: <20210427063604.GH43717@e120937-lin> (raw)
In-Reply-To: <20210427033031.4580-1-wanjiabing@vivo.com>
Hi,
On Tue, Apr 27, 2021 at 11:30:31AM +0800, Wan Jiabing wrote:
> struct scmi_protocol_handle is declared at 34th line.
> The declaration here is duplicate. Remove it.
>
You're right.
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Thanks,
Cristian
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/firmware/arm_scmi/notify.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/firmware/arm_scmi/notify.h b/drivers/firmware/arm_scmi/notify.h
> index ce0324be6c71..4e9b627edfef 100644
> --- a/drivers/firmware/arm_scmi/notify.h
> +++ b/drivers/firmware/arm_scmi/notify.h
> @@ -79,8 +79,6 @@ struct scmi_protocol_events {
>
> int scmi_notification_init(struct scmi_handle *handle);
> void scmi_notification_exit(struct scmi_handle *handle);
> -
> -struct scmi_protocol_handle;
> int scmi_register_protocol_events(const struct scmi_handle *handle, u8 proto_id,
> const struct scmi_protocol_handle *ph,
> const struct scmi_protocol_events *ee);
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-27 6:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 3:30 [PATCH] firmware: arm_scmi: Remove repeated struct declaration Wan Jiabing
2021-04-27 6:36 ` Cristian Marussi [this message]
2021-04-28 10:03 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210427063604.GH43717@e120937-lin \
--to=cristian.marussi@arm.com \
--cc=kael_w@yeah.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox