From: Bjorn Helgaas <helgaas@kernel.org>
To: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-pci@vger.kernel.org, punit1.agrawal@toshiba.co.jp,
yuji2.ishikawa@toshiba.co.jp,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] PCI: dwc: Visconti: PCIe RC controller driver
Date: Mon, 10 May 2021 15:49:28 -0500 [thread overview]
Message-ID: <20210510204928.GA2299570@bjorn-Precision-5520> (raw)
In-Reply-To: <20210510074736.jlxq44o3duwlmylo@toshiba.co.jp>
On Mon, May 10, 2021 at 04:47:36PM +0900, Nobuhiro Iwamatsu wrote:
> On Thu, Apr 29, 2021 at 06:10:40PM -0500, Bjorn Helgaas wrote:
> > > +#define PCIE_UL_EDMA_INT3 BIT(5)
> > > +#define PCIE_UL_S_INT_EVENT_MASK1_ALL (PCIE_UL_CFG_PME_INT | PCIE_UL_CFG_LINK_EQ_REQ_INT | \
> > > + PCIE_UL_EDMA_INT0 | PCIE_UL_EDMA_INT1 | \
> > > + PCIE_UL_EDMA_INT2 | PCIE_UL_EDMA_INT3)
> > > +
> >
> > Please wrap the code here and below so it fits nicely in 80 columns.
>
> checkpatch.pl allows up to 100 characters, is this a PCI driver rule?
The general rule is "match what's around you." So I guess that makes
it a drivers/pci/ rule.
> > > + pp->irq = platform_get_irq_byname(pdev, "intr");
> > > + if (pp->irq < 0) {
> > > + dev_err(dev, "interrupt intr is missing");
> >
> > Make your error messages consistently capitalized (or consistently not
> > capitalized).
>
> Sorry, I didn't understand this point correctly.
> Does this mean capitalize the first letter of the message?
Some of your messages are capitalized and others are not:
dev_info(pci->dev, "Link failure\n"
dev_err(dev, "Failed to get refclk clock: %ld\n"
dev_err(dev, "Failed to get sysclk clock: %ld\n"
dev_err(dev, "Failed to get auxclk clock: %ld\n"
dev_err(dev, "interrupt intr is missing"
dev_dbg(dev, "Applied default link speed\n"
dev_dbg(dev, "link speed Gen %d"
dev_err(dev, "Failed to initialize host\n"
I don't really care whether they're all capitalized or none are
capitalized, but they should all be the same. Otherwise it just looks
sloppy.
Bjorn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-10 20:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 6:35 [PATCH v2 0/3] PCI: dwc: Visoconti: PCIe RC controller driver Nobuhiro Iwamatsu
2021-04-19 6:35 ` [PATCH v2 1/3] dt-bindings: pci: Add DT binding for Toshiba Visconti PCIe controller Nobuhiro Iwamatsu
2021-04-19 6:35 ` [PATCH v2 2/3] PCI: dwc: Visconti: PCIe RC controller driver Nobuhiro Iwamatsu
2021-04-29 23:10 ` Bjorn Helgaas
2021-05-10 7:47 ` Nobuhiro Iwamatsu
2021-05-10 20:49 ` Bjorn Helgaas [this message]
2021-04-19 6:35 ` [PATCH v2 3/3] MAINTAINERS: Add entries for Toshiba Visconti PCIe controller Nobuhiro Iwamatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210510204928.GA2299570@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=punit1.agrawal@toshiba.co.jp \
--cc=robh+dt@kernel.org \
--cc=yuji2.ishikawa@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox