Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: will@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] arm_pmu: move to use request_irq by IRQF_NO_AUTOEN flag
Date: Wed, 2 Jun 2021 11:14:13 +0100	[thread overview]
Message-ID: <20210602101413.GA12753@C02TD0UTHF1T.local> (raw)
In-Reply-To: <1622595642-61678-2-git-send-email-tiantao6@hisilicon.com>

On Wed, Jun 02, 2021 at 09:00:41AM +0800, Tian Tao wrote:
> request_irq() after setting IRQ_NOAUTOEN as below
> irq_set_status_flags(irq, IRQ_NOAUTOEN);
> request_irq(dev, irq...);
> can be replaced by request_irq() with IRQF_NO_AUTOEN flag.
> 
> this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
> is being merged: https://lore.kernel.org/patchwork/patch/1388765/
> 
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>

I see that the patch above was merged in v5.13-rc1 as commit:

  cbe16f35bee6880b ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()")

With that in mind:

Acked-by: Mark Rutland <mark.rutland@arm.com>

... I expect Will will pick this up.

Thanks,
Mark.

> ---
>  drivers/perf/arm_pmu.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
> index e57b348..eb3a802 100644
> --- a/drivers/perf/arm_pmu.c
> +++ b/drivers/perf/arm_pmu.c
> @@ -644,11 +644,9 @@ int armpmu_request_irq(int irq, int cpu)
>  		}
>  
>  		irq_flags = IRQF_PERCPU |
> -			    IRQF_NOBALANCING |
> +			    IRQF_NOBALANCING | IRQF_NO_AUTOEN |
>  			    IRQF_NO_THREAD;
>  
> -		irq_set_status_flags(irq, IRQ_NOAUTOEN);
> -
>  		err = request_nmi(irq, handler, irq_flags, "arm-pmu",
>  				  per_cpu_ptr(&cpu_armpmu, cpu));
>  
> -- 
> 2.7.4
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-02 10:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02  1:00 [PATCH 0/2] move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
2021-06-02  1:00 ` [PATCH 1/2] arm_pmu: " Tian Tao
2021-06-02 10:14   ` Mark Rutland [this message]
2021-06-02  1:00 ` [PATCH 2/2] perf: qcom_l2_pmu: " Tian Tao
2021-06-02 10:16   ` Mark Rutland
2021-06-02 17:06 ` [PATCH 0/2] " Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210602101413.GA12753@C02TD0UTHF1T.local \
    --to=mark.rutland@arm.com \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=tiantao6@hisilicon.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox