From: Vladimir Oltean <olteanv@gmail.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org, Li Yang <leoyang.li@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH] arm64: dts: fix node name for the sysclk
Date: Mon, 14 Jun 2021 17:51:29 +0300 [thread overview]
Message-ID: <20210614145129.63v2tau6ly6wtqbm@skbuf> (raw)
In-Reply-To: <20210612075346.GZ29138@dragon>
Hello Shawn,
On Sat, Jun 12, 2021 at 03:53:47PM +0800, Shawn Guo wrote:
> On Tue, Jun 08, 2021 at 02:26:58PM +0300, Vladimir Oltean wrote:
> > From: Vladimir Oltean <vladimir.oltean@nxp.com>
> >
> > U-Boot attempts to fix up the "clock-frequency" property of the "/sysclk" node:
> > https://elixir.bootlin.com/u-boot/v2021.04/source/arch/arm/cpu/armv8/fsl-layerscape/fdt.c#L512
> >
> > but fails to do so:
> >
> > ## Booting kernel from Legacy Image at a1000000 ...
> > Image Name:
> > Created: 2021-06-08 10:31:38 UTC
> > Image Type: AArch64 Linux Kernel Image (gzip compressed)
> > Data Size: 15431370 Bytes = 14.7 MiB
> > Load Address: 80080000
> > Entry Point: 80080000
> > Verifying Checksum ... OK
> > ## Flattened Device Tree blob at a0000000
> > Booting using the fdt blob at 0xa0000000
> > Uncompressing Kernel Image
> > Loading Device Tree to 00000000fbb19000, end 00000000fbb22717 ... OK
> > Unable to update property /sysclk:clock-frequency, err=FDT_ERR_NOTFOUND
> >
> > Starting kernel ...
> >
> > All Layerscape SoCs except LS1028A use "sysclk" as the node name, and
> > not "clock-sysclk". So change the node name of LS1028A accordingly.
>
> Wouldn't it more flexible to use alias/label for finding the node?
> Using node name/path looks fragile.
Thank you for the advice, I will keep it in mind next time when I design
my own bootloader device tree fixup scheme. However, in this case I did
not create it, and implementing your suggestion to find the sysclk node
through /aliases would require changes not only to the bootloader, but
to the Linux device tree still (and if we're modifying the Linux DT, why
not just go with this patch). So yes, the existing mechanism is more
fragile, but I am not sure if we gain anything by artificially creating
an additional dependency in the process.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-14 14:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 11:26 [PATCH] arm64: dts: fix node name for the sysclk Vladimir Oltean
2021-06-08 11:31 ` Vladimir Oltean
2021-06-12 7:53 ` Shawn Guo
2021-06-14 14:51 ` Vladimir Oltean [this message]
2021-07-14 2:29 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614145129.63v2tau6ly6wtqbm@skbuf \
--to=olteanv@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox