Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Cristian Marussi <cristian.marussi@arm.com>
To: Adam Borowski <kilobyte@angband.pl>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] firmware: arm_scmi: fix build failure if ARM_SCMI_PROTOCOL=y VIRTIO=m
Date: Mon, 13 Sep 2021 09:55:01 +0100	[thread overview]
Message-ID: <20210913085501.GA22275@e120937-lin> (raw)
In-Reply-To: <20210912212725.11909-1-kilobyte@angband.pl>

On Sun, Sep 12, 2021 at 11:27:25PM +0200, Adam Borowski wrote:
> A "bool" for a subfeature doesn't force the dependency by itself.
> 
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
> ---

Hi Adam,

thanks for this fix, BUT it was already spotted by LKP

https://lore.kernel.org/linux-mm/202108151230.lcHk2Pkk-lkp@intel.com/

and a proposed fix is already queued on sudeep/for-next/scmi.

https://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git/commit/?h=for-next/scmi&id=7b4262378924a9985bc4c35ea015bd48dfe57792

I supposed it will picked up with the next 5.15 scmi fixes.

Probably the original distribution list was a bit odd since I replied to
the above original LKP mail recipients, apologies for this.

Thanks,
Cristian

>  drivers/firmware/arm_scmi/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/Kconfig
> index 7f4d2435503b..cca557bc625b 100644
> --- a/drivers/firmware/arm_scmi/Kconfig
> +++ b/drivers/firmware/arm_scmi/Kconfig
> @@ -68,7 +68,7 @@ config ARM_SCMI_TRANSPORT_SMC
>  
>  config ARM_SCMI_TRANSPORT_VIRTIO
>  	bool "SCMI transport based on VirtIO"
> -	depends on VIRTIO
> +	depends on VIRTIO >= ARM_SCMI_PROTOCOL
>  	select ARM_SCMI_HAVE_TRANSPORT
>  	select ARM_SCMI_HAVE_MSG
>  	help
> -- 
> 2.33.0
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-13  8:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-12 21:27 [PATCH] firmware: arm_scmi: fix build failure if ARM_SCMI_PROTOCOL=y VIRTIO=m Adam Borowski
2021-09-13  8:55 ` Cristian Marussi [this message]
2021-09-13 10:35   ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210913085501.GA22275@e120937-lin \
    --to=cristian.marussi@arm.com \
    --cc=kilobyte@angband.pl \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox