From: Leo Yan <leo.yan@linaro.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Mike Leach <mike.leach@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] coresight: Update comments for removing cs_etm_find_snapshot()
Date: Tue, 14 Sep 2021 18:08:47 +0800 [thread overview]
Message-ID: <20210914100847.GD1538480@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <f6700a4d-80e1-cd53-232c-0e26f7179d1b@arm.com>
On Tue, Sep 14, 2021 at 10:27:26AM +0100, Suzuki Kuruppassery Poulose wrote:
[...]
> > diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> > index d23c7690f29a..ce14eb83925c 100644
> > --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c
> > +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> > @@ -1573,9 +1573,8 @@ tmc_update_etr_buffer(struct coresight_device *csdev,
> > /*
> > * In snapshot mode we simply increment the head by the number of byte
> > - * that were written. User space function cs_etm_find_snapshot() will
> > - * figure out how many bytes to get from the AUX buffer based on the
> > - * position of the head.
> > + * that were written. User space will figure out how many bytes to get
> > + * from the AUX buffer based on the position of the head.
> > */
> > if (etr_perf->snapshot)
> > handle->head += size;
> >
>
>
> Thanks for the revised patch, I have queued both the patches.
Cool, and thanks Suzuki!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-09-14 10:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-12 12:57 [PATCH v4 0/2] coresight: Fix for snapshot mode Leo Yan
2021-09-12 12:57 ` [PATCH v4 1/2] coresight: tmc-etr: Use perf_output_handle::head for AUX ring buffer Leo Yan
2021-09-12 12:57 ` [PATCH v4 2/2] coresight: Update comments for removing cs_etm_find_snapshot() Leo Yan
2021-09-14 9:27 ` Suzuki K Poulose
2021-09-14 10:08 ` Leo Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210914100847.GD1538480@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox