* Re: [PATCH v4 1/1] iio: mtk-auxadc: fix case IIO_CHAN_INFO_PROCESSED [not found] ` <20210926073028.11045-2-hui.liu@mediatek.com> @ 2021-09-26 11:30 ` Jonathan Cameron 2021-10-31 16:49 ` Hsin-Yi Wang 0 siblings, 1 reply; 2+ messages in thread From: Jonathan Cameron @ 2021-09-26 11:30 UTC (permalink / raw) To: Hui-Liu Liu Cc: robh+dt, lars, pmeerw, srv_heupstream, zhiyong.tao, chun-hung.wu, yingjoe.chen, seiya.wang, ben.tseng, matthias.bgg, s.hauer, devicetree, linux-kernel, linux-arm-kernel, linux-iio, linux-mediatek On Sun, 26 Sep 2021 15:30:28 +0800 Hui-Liu Liu <hui.liu@mediatek.com> wrote: > From: Hui Liu <hui.liu@mediatek.com> > > The previous driver does't apply the necessary scaling to take the > voltage range into account. > We change readback value from raw data to input voltage to fix case > IIO_CHAN_INFO_PROCESSED. > > Fixes: ace4cdfe67be ("iio: adc: mt2701: Add Mediatek auxadc driver for mt2701.") > Signed-off-by: Hui Liu <hui.liu@mediatek.com> Hi Hui Liu, Thanks for the updated description. Applied to the fixes-togreg branch of iio.git and marked for stable. Thanks, Jonathan > --- > drivers/iio/adc/mt6577_auxadc.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c > index 79c1dd68b909..d4fccd52ef08 100644 > --- a/drivers/iio/adc/mt6577_auxadc.c > +++ b/drivers/iio/adc/mt6577_auxadc.c > @@ -82,6 +82,10 @@ static const struct iio_chan_spec mt6577_auxadc_iio_channels[] = { > MT6577_AUXADC_CHANNEL(15), > }; > > +/* For Voltage calculation */ > +#define VOLTAGE_FULL_RANGE 1500 /* VA voltage */ > +#define AUXADC_PRECISE 4096 /* 12 bits */ > + > static int mt_auxadc_get_cali_data(int rawdata, bool enable_cali) > { > return rawdata; > @@ -191,6 +195,10 @@ static int mt6577_auxadc_read_raw(struct iio_dev *indio_dev, > } > if (adc_dev->dev_comp->sample_data_cali) > *val = mt_auxadc_get_cali_data(*val, true); > + > + /* Convert adc raw data to voltage: 0 - 1500 mV */ > + *val = *val * VOLTAGE_FULL_RANGE / AUXADC_PRECISE; > + > return IIO_VAL_INT; > > default: _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v4 1/1] iio: mtk-auxadc: fix case IIO_CHAN_INFO_PROCESSED 2021-09-26 11:30 ` [PATCH v4 1/1] iio: mtk-auxadc: fix case IIO_CHAN_INFO_PROCESSED Jonathan Cameron @ 2021-10-31 16:49 ` Hsin-Yi Wang 0 siblings, 0 replies; 2+ messages in thread From: Hsin-Yi Wang @ 2021-10-31 16:49 UTC (permalink / raw) To: Hui-Liu Liu Cc: robh+dt, lars, pmeerw, srv_heupstream, zhiyong.tao, chun-hung.wu, yingjoe.chen, seiya.wang, ben.tseng, matthias.bgg, s.hauer, devicetree, linux-kernel, linux-arm-kernel, linux-iio, linux-mediatek, Jonathan Cameron On Sun, Sep 26, 2021 at 7:26 PM Jonathan Cameron <jic23@kernel.org> wrote: > > On Sun, 26 Sep 2021 15:30:28 +0800 > Hui-Liu Liu <hui.liu@mediatek.com> wrote: > > > From: Hui Liu <hui.liu@mediatek.com> > > > > The previous driver does't apply the necessary scaling to take the > > voltage range into account. > > We change readback value from raw data to input voltage to fix case > > IIO_CHAN_INFO_PROCESSED. > > > > Fixes: ace4cdfe67be ("iio: adc: mt2701: Add Mediatek auxadc driver for mt2701.") > > Signed-off-by: Hui Liu <hui.liu@mediatek.com> > Hi Hui Liu, After this patch, mt8183 tboard thermal sensor[1] is getting incorrect value: Before the patch: /sys/class/thermal/thermal_zone0/temp:41488 (cpu) /sys/class/thermal/thermal_zone7/temp:35433 (tboard) /sys/class/thermal/thermal_zone8/temp:33709 (tboard) After the patch: /sys/class/thermal/thermal_zone0/temp:40365 (cpu) /sys/class/thermal/thermal_zone7/temp:69781 (tboard) /sys/class/thermal/thermal_zone8/temp:69014 (tboard) [1] https://elixir.bootlin.com/linux/v5.15-rc7/source/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi#L862 > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-31 16:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210926073028.11045-1-hui.liu@mediatek.com>
[not found] ` <20210926073028.11045-2-hui.liu@mediatek.com>
2021-09-26 11:30 ` [PATCH v4 1/1] iio: mtk-auxadc: fix case IIO_CHAN_INFO_PROCESSED Jonathan Cameron
2021-10-31 16:49 ` Hsin-Yi Wang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox