From: Sudeep Holla <sudeep.holla@arm.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
Guillaume Tucker <guillaume.tucker@collabora.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: dts: vexpress: Fix motherboard bus 'interrupt-map'
Date: Mon, 27 Sep 2021 11:48:21 +0100 [thread overview]
Message-ID: <20210927104821.pmm33yarfpujgfjm@bogus> (raw)
In-Reply-To: <20210924214221.1877686-1-robh@kernel.org>
On Fri, Sep 24, 2021 at 04:42:21PM -0500, Rob Herring wrote:
> Commit 078fb7aa6a83 ("arm: dts: vexpress: Fix addressing issues with
> 'motherboard-bus' nodes") broke booting on a couple of 32-bit VExpress
> boards. The problem is #address-cells size changed, but interrupt-map
> was not updated. This results in the timer interrupt (and all the
> other motherboard interrupts) not getting mapped.
>
> As the 'interrupt-map' properties are all just duplicates across boards,
> just move them into vexpress-v2m.dtsi and vexpress-v2m-rs1.dtsi.
> Strictly speaking, 'interrupt-map' is dependent on the parent
> interrupt controller, but it's not likely we'll ever have a different
> parent than GICv2 on these old platforms. If there was one,
> 'interrupt-map' can still be overridden.
>
> Fixes: 078fb7aa6a83 ("arm: dts: vexpress: Fix addressing issues with 'motherboard-bus' nodes")
> Reported-by: Reported-by: "kernelci.org bot" <bot@kernelci.org>
> Cc: Guillaume Tucker <guillaume.tucker@collabora.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> I tested this on QEMU VExpress CA9. I also added a check to dtc for
> 'interrupt-map' to catch this kind of error. I need to run it on the
> rest of the tree and upstream it before enabling in the kernel.
>
Thanks for fixing this quickly. This time I tested on both Juno and TC2.
Sorry I missed to test it on TC2 earlier as the board was not accessible.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-09-27 10:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 21:42 [PATCH] arm: dts: vexpress: Fix motherboard bus 'interrupt-map' Rob Herring
2021-09-27 10:42 ` Sudeep Holla
2021-09-27 10:48 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210927104821.pmm33yarfpujgfjm@bogus \
--to=sudeep.holla@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=guillaume.tucker@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox