From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Anshuman Khandual <anshuman.khandual@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Barry Song <song.bao.hua@hisilicon.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] arm64/hugetlb: fix CMA gigantic page order for non-4K PAGE_SIZE
Date: Tue, 5 Oct 2021 16:15:42 -0700 [thread overview]
Message-ID: <20211005161542.176a63eb7e197d795c5196d9@linux-foundation.org> (raw)
In-Reply-To: <3747d914-c687-b983-c624-e3418b4d2448@oracle.com>
On Tue, 5 Oct 2021 14:28:03 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote:
> On 10/5/21 1:54 PM, Andrew Morton wrote:
> > On Tue, 5 Oct 2021 13:25:29 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote:
> >
> >> For non-4K PAGE_SIZE configs, the largest gigantic huge page size is
> >> CONT_PMD_SHIFT order.
> >
> > What are the user visible effects of this bug?
> >
> >
>
> Sorry,
> I only recently got easy access to arm64 platforms. This is what I saw
> as a user:
>
> The largest gigantic huge page size on arm64 with 64K PAGE_SIZE 64K is
> 16G. Therefore, one should be able to specify 'hugetlb_cma=16G' on the
> kernel command line so that 1 gigantic page can be allocated from CMA.
> However, when adding such an option the following message is produced:
>
> hugetlb_cma: cma area should be at least 8796093022208 MiB
>
> This is because the calculation for non-4K gigantic page order is
> incorrect in the arm64 specific routine arm64_hugetlb_cma_reserve().
Cool, thanks.
> Would you like me to send a new version with this in the commit message?
> Or, is it easier for you to just add it?
I assumed that it would be merged via the same path as the offending
abb7962adc80. Catalin's arm tree, it appears.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-05 23:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 20:25 [PATCH] arm64/hugetlb: fix CMA gigantic page order for non-4K PAGE_SIZE Mike Kravetz
2021-10-05 20:54 ` Andrew Morton
2021-10-05 21:28 ` Mike Kravetz
2021-10-05 23:15 ` Andrew Morton [this message]
2021-10-06 7:55 ` Anshuman Khandual
2021-10-06 13:06 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005161542.176a63eb7e197d795c5196d9@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.kravetz@oracle.com \
--cc=song.bao.hua@hisilicon.com \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox