Re: [PATCH v2 8/8] iio: dac: ti-dac7311: Make use of the helper function dev_err_probe()

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 28 Sep 2021 09:39:01 +0800
Cai Huoqing <caihuoqing@baidu.com> wrote:

> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Series applied to the togreg branch of iio.git and pushed out as testing for
0-day to see if it can find any problems before I push this out in a place
where it can make a mess of linux-next

Thanks,

Jonathan

> ---
>  drivers/iio/dac/ti-dac7311.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/dac/ti-dac7311.c b/drivers/iio/dac/ti-dac7311.c
> index 9d0b253be841..09218c3029f0 100644
> --- a/drivers/iio/dac/ti-dac7311.c
> +++ b/drivers/iio/dac/ti-dac7311.c
> @@ -266,10 +266,9 @@ static int ti_dac_probe(struct spi_device *spi)
>  	ti_dac->resolution = spec->resolution;
>  
>  	ti_dac->vref = devm_regulator_get(dev, "vref");
> -	if (IS_ERR(ti_dac->vref)) {
> -		dev_err(dev, "error to get regulator\n");
> -		return PTR_ERR(ti_dac->vref);
> -	}
> +	if (IS_ERR(ti_dac->vref))
> +		return dev_err_probe(dev, PTR_ERR(ti_dac->vref),
> +				     "error to get regulator\n");
>  
>  	ret = regulator_enable(ti_dac->vref);
>  	if (ret < 0) {


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel