From: Sudeep Holla <sudeep.holla@arm.com>
To: trix@redhat.com
Cc: cristian.marussi@arm.com, linux-arm-kernel@lists.infradead.org,
Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: arm_scmi: replace resevered identifiers in macros
Date: Wed, 22 Dec 2021 18:15:11 +0000 [thread overview]
Message-ID: <20211222181511.n262joky3gw7h2gr@bogus> (raw)
In-Reply-To: <20211222172519.3209478-1-trix@redhat.com>
On Wed, Dec 22, 2021 at 09:25:19AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Identifiers starting with __ are resevered. Replace __X with X.
>
> The arguments to these macros are pointers. The macros only reads
> values. There is no need to make copies of the pointers, use them
> directly.
>
Agreed and thanks for the patch.
However the original patch was modified and these macros were moved
to inline functions[0] after the initial build warnings from the
build bot[1]. Sorry my reply to the bot seems to have got lost and didn't
make it to the list.
--
Regards,
Sudeep
[0] https://git.kernel.org/sudeep.holla/c/a690b7e6e7
[1] https://lore.kernel.org/lkml/202112211457.TlWRYcoq-lkp@intel.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-12-22 18:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 17:25 [PATCH] firmware: arm_scmi: replace resevered identifiers in macros trix
2021-12-22 18:15 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211222181511.n262joky3gw7h2gr@bogus \
--to=sudeep.holla@arm.com \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox