From: Will Deacon <will@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
Luis Machado <luis.machado@linaro.org>,
John Baldwin <jhb@FreeBSD.org>, Arnd Bergmann <arnd@arndb.de>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Szabolcs Nagy <szabolcs.nagy@arm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 1/5] elfcore: Replace CONFIG_{IA64,UML} checks with a new option
Date: Tue, 15 Feb 2022 17:39:30 +0000 [thread overview]
Message-ID: <20220215173930.GA8706@willie-the-truck> (raw)
In-Reply-To: <20220131165456.2160675-2-catalin.marinas@arm.com>
On Mon, Jan 31, 2022 at 04:54:52PM +0000, Catalin Marinas wrote:
> As arm64 is about to introduce MTE-specific phdrs in the core dump, add
> a common CONFIG_ARCH_BINFMT_ELF_EXTRA_PHDRS option currently selectable
> by UML_X86 and IA64.
>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Eric Biederman <ebiederm@xmission.com>
> ---
> arch/ia64/Kconfig | 1 +
> arch/x86/um/Kconfig | 1 +
> fs/Kconfig.binfmt | 3 +++
> include/linux/elfcore.h | 4 ++--
> 4 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
> index a7e01573abd8..e003b2473c64 100644
> --- a/arch/ia64/Kconfig
> +++ b/arch/ia64/Kconfig
> @@ -8,6 +8,7 @@ menu "Processor type and features"
>
> config IA64
> bool
> + select ARCH_BINFMT_ELF_EXTRA_PHDRS
> select ARCH_HAS_DMA_MARK_CLEAN
> select ARCH_HAS_STRNCPY_FROM_USER
> select ARCH_HAS_STRNLEN_USER
> diff --git a/arch/x86/um/Kconfig b/arch/x86/um/Kconfig
> index 40d6a06e41c8..ead7e5b3a975 100644
> --- a/arch/x86/um/Kconfig
> +++ b/arch/x86/um/Kconfig
> @@ -8,6 +8,7 @@ endmenu
>
> config UML_X86
> def_bool y
> + select ARCH_BINFMT_ELF_EXTRA_PHDRS if X86_32
>
> config 64BIT
> bool "64-bit kernel" if "$(SUBARCH)" = "x86"
> diff --git a/fs/Kconfig.binfmt b/fs/Kconfig.binfmt
> index 4d5ae61580aa..68e586283764 100644
> --- a/fs/Kconfig.binfmt
> +++ b/fs/Kconfig.binfmt
> @@ -36,6 +36,9 @@ config COMPAT_BINFMT_ELF
> config ARCH_BINFMT_ELF_STATE
> bool
>
> +config ARCH_BINFMT_ELF_EXTRA_PHDRS
> + bool
> +
> config ARCH_HAVE_ELF_PROT
> bool
>
> diff --git a/include/linux/elfcore.h b/include/linux/elfcore.h
> index 746e081879a5..b02d5fc711db 100644
> --- a/include/linux/elfcore.h
> +++ b/include/linux/elfcore.h
> @@ -114,7 +114,7 @@ static inline int elf_core_copy_task_fpregs(struct task_struct *t, struct pt_reg
> #endif
> }
>
> -#if (defined(CONFIG_UML) && defined(CONFIG_X86_32)) || defined(CONFIG_IA64)
> +#ifdef CONFIG_ARCH_BINFMT_ELF_EXTRA_PHDRS
> /*
> * These functions parameterize elf_core_dump in fs/binfmt_elf.c to write out
> * extra segments containing the gate DSO contents. Dumping its
> @@ -149,6 +149,6 @@ static inline size_t elf_core_extra_data_size(void)
> {
> return 0;
> }
> -#endif
> +#endif /* CONFIG_ARCH_EXTRA_PHDRS */
nit: closing comment doesn't match the name of the new Kconfig symbol.
I'll fix that and put the series into -next.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-15 17:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 16:54 [PATCH v2 0/5] arm64: mte: add core dump support Catalin Marinas
2022-01-31 16:54 ` [PATCH v2 1/5] elfcore: Replace CONFIG_{IA64, UML} checks with a new option Catalin Marinas
2022-02-15 17:39 ` Will Deacon [this message]
2022-01-31 16:54 ` [PATCH v2 2/5] elf: Introduce the ARM MTE ELF segment type Catalin Marinas
2022-01-31 16:54 ` [PATCH v2 3/5] arm64: mte: Define the number of bytes for storing the tags in a page Catalin Marinas
2022-01-31 16:54 ` [PATCH v2 4/5] arm64: mte: Dump the MTE tags in the core file Catalin Marinas
2022-02-02 17:55 ` Mark Brown
2022-01-31 16:54 ` [PATCH v2 5/5] arm64: mte: Document the core dump file format Catalin Marinas
2022-02-15 23:18 ` [PATCH v2 0/5] arm64: mte: add core dump support Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220215173930.GA8706@willie-the-truck \
--to=will@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=ebiederm@xmission.com \
--cc=jhb@FreeBSD.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=luis.machado@linaro.org \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox