From: Jonathan Cameron <jic23@kernel.org>
To: Michal Simek <monstr@monstr.eu>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] iio: adc: xilinx-ams: Use devm_delayed_work_autocancel() to simplify code
Date: Sat, 26 Feb 2022 16:43:00 +0000 [thread overview]
Message-ID: <20220226164300.63b31841@jic23-huawei> (raw)
In-Reply-To: <f874a9c7-8d8d-fecc-8fc9-51dcf37cf60b@monstr.eu>
On Mon, 21 Feb 2022 11:02:00 +0100
Michal Simek <monstr@monstr.eu> wrote:
> Hi,
>
> On 2/20/22 12:45, Jonathan Cameron wrote:
> > On Sun, 13 Feb 2022 19:29:05 +0100
> > Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> >
> >> Use devm_delayed_work_autocancel() instead of hand writing it. This is
> >> less verbose and saves a few lines of code.
> >>
> >> devm_delayed_work_autocancel() uses devm_add_action() instead of
> >> devm_add_action_or_reset(). This is fine, because if the underlying memory
> >> allocation fails, no work has been scheduled yet. So there is nothing to
> >> undo.
> >>
> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > Looks good to me, but I'd ideally like some input from someone familiar with
> > the driver.
>
> Anand told me that the change is fine that's why here is my
> Acked-by: Michal Simek <michal.simek@xilinx.com>
>
> Jonathan: Anand decided to do change in his carrier that's why that emails won't
> go through. But I am still around if you need something xilinx/amd to test.
>
> Thanks,
> Michal
Thanks Michal and best wishes to Anand for whatever comes next!
Applied to the togreg branch of iio.git and pushed out as testing for
0-day to take a quick look before I expose this to linux-next.
Thanks,
Jonathan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-02-26 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-13 18:29 [PATCH] iio: adc: xilinx-ams: Use devm_delayed_work_autocancel() to simplify code Christophe JAILLET
2022-02-20 11:45 ` Jonathan Cameron
2022-02-21 10:02 ` Michal Simek
2022-02-26 16:43 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220226164300.63b31841@jic23-huawei \
--to=jic23@kernel.org \
--cc=anand.ashok.dumbre@xilinx.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox