From: Coiby Xu <coxu@redhat.com>
To: Baoquan He <bhe@redhat.com>
Cc: Coiby Xu <coiby.xu@gmail.com>,
kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
Dave Young <dyoung@redhat.com>, Will Deacon <will@kernel.org>,
"Eric W . Biederman" <ebiederm@xmission.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH v3 1/3] kexec: clean up arch_kexec_kernel_verify_sig
Date: Fri, 18 Mar 2022 17:43:20 +0800 [thread overview]
Message-ID: <20220318094320.aoia7yahtmy2hksp@Rk> (raw)
In-Reply-To: <YjRIqdAH2nV+DRgW@MiWiFi-R3L-srv>
On Fri, Mar 18, 2022 at 04:54:01PM +0800, Baoquan He wrote:
[...]
>> Btw, checkpatch.pl seems to requires referring to a specific commit on
>> the same line,
>>
>> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9ec4ecef0af7 ("kexec_file,x86,powerpc: factor out kexec_file_ops functions")'
>> #6: commit 9ec4ecef0af7 ("kexec_file,x86, powerpc: factor out
>> kexec_file_ops
>> functions") allows implementing the arch-specific implementation of kernel
>> total: 1 errors, 0 warnings, 61 lines checked
>> NOTE: For some of the reported defects, checkpatch may be able to
>> mechanically convert to the typical style using --fix or --fix-inplace.
>> "[PATCH] kexec: clean up arch_kexec_kernel_verify_sig" has style problems, please review.
>> NOTE: If any of the errors are false positives, please report
>> them to the maintainer, see CHECKPATCH in MAINTAINERS.
>>
>> Is this a false positive?
>
>No, it's not. Youp probably copied the commit subject and modified it.
>Please copy below two lines into your patch to replace and try again.
>
>commit 9ec4ecef0af7 ("kexec_file,x86,powerpc: factor out kexec_file_ops
>functions")
Yes, you are right. I unintentionally changed the subject. I've sent
v4 to fix this commit reference issue and other checkpatch.pl warnings.
Thanks!
--
Best regards,
Coiby
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-18 9:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 2:03 [RESEND PATCH v3 0/3] use more system keyrings to verify arm64 kdump kernel image signature Coiby Xu
2022-03-04 2:03 ` [RESEND PATCH v3 1/3] kexec: clean up arch_kexec_kernel_verify_sig Coiby Xu
2022-03-17 12:45 ` Baoquan He
2022-03-18 2:48 ` Coiby Xu
2022-03-18 3:27 ` Baoquan He
2022-03-18 7:18 ` Coiby Xu
2022-03-18 8:54 ` Baoquan He
2022-03-18 9:43 ` Coiby Xu [this message]
2022-03-04 2:03 ` [RESEND PATCH v3 2/3] kexec, KEYS: make the code in bzImage64_verify_sig generic Coiby Xu
2022-03-04 2:03 ` [RESEND PATCH v3 3/3] arm64: kexec_file: use more system keyrings to verify kernel image signature Coiby Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220318094320.aoia7yahtmy2hksp@Rk \
--to=coxu@redhat.com \
--cc=bhe@redhat.com \
--cc=coiby.xu@gmail.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox