[PATCH] firmware: ti_sci: Fix devm_ti_sci_get_resource() stub

[PATCH] firmware: ti_sci: Fix devm_ti_sci_get_resource() stub

[Philipp Zabel]

Fix build errors when including linux/soc/ti/ti_sci_protocol.h with
CONFIG_TI_SCI_PROTOCOL disabled.

This allows to build the reset-ti-sci driver under CONFIG_COMPILE_TEST.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 include/linux/soc/ti/ti_sci_protocol.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/soc/ti/ti_sci_protocol.h b/include/linux/soc/ti/ti_sci_protocol.h
index 0aad7009b50e..bd0d11af76c5 100644
--- a/include/linux/soc/ti/ti_sci_protocol.h
+++ b/include/linux/soc/ti/ti_sci_protocol.h
@@ -645,7 +645,7 @@ devm_ti_sci_get_of_resource(const struct ti_sci_handle *handle,
 
 static inline struct ti_sci_resource *
 devm_ti_sci_get_resource(const struct ti_sci_handle *handle, struct device *dev,
-			 u32 dev_id, u32 sub_type);
+			 u32 dev_id, u32 sub_type)
 {
 	return ERR_PTR(-EINVAL);
 }
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] firmware: ti_sci: Fix devm_ti_sci_get_resource() stub

[Nishanth Menon]

On 19:40-20220323, Philipp Zabel wrote:

[...]

> diff --git a/include/linux/soc/ti/ti_sci_protocol.h b/include/linux/soc/ti/ti_sci_protocol.h
> index 0aad7009b50e..bd0d11af76c5 100644
> --- a/include/linux/soc/ti/ti_sci_protocol.h
> +++ b/include/linux/soc/ti/ti_sci_protocol.h
> @@ -645,7 +645,7 @@ devm_ti_sci_get_of_resource(const struct ti_sci_handle *handle,
>  
>  static inline struct ti_sci_resource *
>  devm_ti_sci_get_resource(const struct ti_sci_handle *handle, struct device *dev,
> -			 u32 dev_id, u32 sub_type);
> +			 u32 dev_id, u32 sub_type)

Thanks for catching this..

However, I think we already applied this patch and is already part of
the PR we sent for 5.18

See [1] which should be Commit 043cfff99a18 ("firmware: ti_sci: Fix
compilation failure when CONFIG_TI_SCI_PROTOCOL is not defined") in
Linus-master.

[1] https://lore.kernel.org/all/e6c3cb793e1a6a2a0ae2528d5a5650dfe6a4b6ff.1640276505.git.christophe.jaillet@wanadoo.fr/
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel