From: Kees Cook <keescook@chromium.org>
To: Joey Gouly <joey.gouly@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, nd@arm.com,
catalin.marinas@arm.com, masahiroy@kernel.org,
vincenzo.frascino@arm.com, will@kernel.org
Subject: Re: [PATCH v1 1/2] arm64: vdso: put ELF related sections in the linker script
Date: Tue, 5 Apr 2022 10:41:23 -0700 [thread overview]
Message-ID: <202204051040.812AD550F@keescook> (raw)
In-Reply-To: <20220405160246.1991-2-joey.gouly@arm.com>
On Tue, Apr 05, 2022 at 05:02:45PM +0100, Joey Gouly wrote:
> These are the same sections as ELF_DETAILS in include/asm-generic/vmlinux.lds.h
Can include/asm-generic/vmlinux.lds.h be included to just use
ELF_DETAILS directly?
Outside of that, yeah, this series looks good. Thanks!
-Kees
>
> Signed-off-by: Joey Gouly <joey.gouly@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
> Cc: Kees Cook <keescook@chromium.org>
> ---
> arch/arm64/kernel/vdso/vdso.lds.S | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/kernel/vdso/vdso.lds.S b/arch/arm64/kernel/vdso/vdso.lds.S
> index a5e61e09ea92..e453e74e98f9 100644
> --- a/arch/arm64/kernel/vdso/vdso.lds.S
> +++ b/arch/arm64/kernel/vdso/vdso.lds.S
> @@ -54,6 +54,11 @@ SECTIONS
> _end = .;
> PROVIDE(end = .);
>
> + .comment 0 : { *(.comment) }
> + .symtab 0 : { *(.symtab) }
> + .strtab 0 : { *(.strtab) }
> + .shstrtab 0 : { *(.shstrtab) }
> +
> /DISCARD/ : {
> *(.data .data.* .gnu.linkonce.d.* .sdata*)
> *(.bss .sbss .dynbss .dynsbss)
> --
> 2.17.1
>
--
Kees Cook
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-05 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 16:02 [PATCH v1 0/2] Enable orphan-handling=warn for VDSO Joey Gouly
2022-04-05 16:02 ` [PATCH v1 1/2] arm64: vdso: put ELF related sections in the linker script Joey Gouly
2022-04-05 17:41 ` Kees Cook [this message]
2022-04-05 16:02 ` [PATCH v1 2/2] arm64: vdso: enable orphan handling for VDSO Joey Gouly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202204051040.812AD550F@keescook \
--to=keescook@chromium.org \
--cc=catalin.marinas@arm.com \
--cc=joey.gouly@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=masahiroy@kernel.org \
--cc=nd@arm.com \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox