* [PATCH 09/11] perf/imx_ddr: Fix undefined behavior due to shift overflowing the constant [not found] <20220405151517.29753-1-bp@alien8.de> @ 2022-04-05 15:15 ` Borislav Petkov 2022-04-08 10:47 ` Will Deacon 0 siblings, 1 reply; 3+ messages in thread From: Borislav Petkov @ 2022-04-05 15:15 UTC (permalink / raw) To: LKML Cc: Frank Li, Will Deacon, Mark Rutland, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, linux-arm-kernel From: Borislav Petkov <bp@suse.de> Fix: In file included from <command-line>:0:0: In function ‘ddr_perf_counter_enable’, inlined from ‘ddr_perf_irq_handler’ at drivers/perf/fsl_imx8_ddr_perf.c:651:2: ././include/linux/compiler_types.h:352:38: error: call to ‘__compiletime_assert_729’ \ declared with attribute error: FIELD_PREP: mask is not constant _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ... See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory details as to why it triggers with older gccs only. Signed-off-by: Borislav Petkov <bp@suse.de> Cc: Frank Li <Frank.li@nxp.com> Cc: Will Deacon <will@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> Cc: Fabio Estevam <festevam@gmail.com> Cc: NXP Linux Team <linux-imx@nxp.com> Cc: linux-arm-kernel@lists.infradead.org --- drivers/perf/fsl_imx8_ddr_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c index 94ebc1ecace7..b1b2a55de77f 100644 --- a/drivers/perf/fsl_imx8_ddr_perf.c +++ b/drivers/perf/fsl_imx8_ddr_perf.c @@ -29,7 +29,7 @@ #define CNTL_OVER_MASK 0xFFFFFFFE #define CNTL_CSV_SHIFT 24 -#define CNTL_CSV_MASK (0xFF << CNTL_CSV_SHIFT) +#define CNTL_CSV_MASK (0xFFU << CNTL_CSV_SHIFT) #define EVENT_CYCLES_ID 0 #define EVENT_CYCLES_COUNTER 0 -- 2.35.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 09/11] perf/imx_ddr: Fix undefined behavior due to shift overflowing the constant 2022-04-05 15:15 ` [PATCH 09/11] perf/imx_ddr: Fix undefined behavior due to shift overflowing the constant Borislav Petkov @ 2022-04-08 10:47 ` Will Deacon 2022-04-08 11:01 ` Borislav Petkov 0 siblings, 1 reply; 3+ messages in thread From: Will Deacon @ 2022-04-08 10:47 UTC (permalink / raw) To: Borislav Petkov Cc: LKML, Frank Li, Mark Rutland, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, linux-arm-kernel On Tue, Apr 05, 2022 at 05:15:15PM +0200, Borislav Petkov wrote: > From: Borislav Petkov <bp@suse.de> > > Fix: > > In file included from <command-line>:0:0: > In function ‘ddr_perf_counter_enable’, > inlined from ‘ddr_perf_irq_handler’ at drivers/perf/fsl_imx8_ddr_perf.c:651:2: > ././include/linux/compiler_types.h:352:38: error: call to ‘__compiletime_assert_729’ \ > declared with attribute error: FIELD_PREP: mask is not constant > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > ... > > See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory > details as to why it triggers with older gccs only. > > Signed-off-by: Borislav Petkov <bp@suse.de> > Cc: Frank Li <Frank.li@nxp.com> > Cc: Will Deacon <will@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: NXP Linux Team <linux-imx@nxp.com> > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/perf/fsl_imx8_ddr_perf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c > index 94ebc1ecace7..b1b2a55de77f 100644 > --- a/drivers/perf/fsl_imx8_ddr_perf.c > +++ b/drivers/perf/fsl_imx8_ddr_perf.c > @@ -29,7 +29,7 @@ > #define CNTL_OVER_MASK 0xFFFFFFFE > > #define CNTL_CSV_SHIFT 24 > -#define CNTL_CSV_MASK (0xFF << CNTL_CSV_SHIFT) > +#define CNTL_CSV_MASK (0xFFU << CNTL_CSV_SHIFT) Acked-by: Will Deacon <will@kernel.org> (let me know if you'd prefer for me to queue this directly) Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 09/11] perf/imx_ddr: Fix undefined behavior due to shift overflowing the constant 2022-04-08 10:47 ` Will Deacon @ 2022-04-08 11:01 ` Borislav Petkov 0 siblings, 0 replies; 3+ messages in thread From: Borislav Petkov @ 2022-04-08 11:01 UTC (permalink / raw) To: Will Deacon Cc: LKML, Frank Li, Mark Rutland, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, linux-arm-kernel On Fri, Apr 08, 2022 at 11:47:40AM +0100, Will Deacon wrote: > (let me know if you'd prefer for me to queue this directly) Yes please. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-08 11:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220405151517.29753-1-bp@alien8.de>
2022-04-05 15:15 ` [PATCH 09/11] perf/imx_ddr: Fix undefined behavior due to shift overflowing the constant Borislav Petkov
2022-04-08 10:47 ` Will Deacon
2022-04-08 11:01 ` Borislav Petkov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox