Re: [PATCH 05/11] dt-bindings: spi: dw: Add Pensando Elba SoC SPI Controller bindings

From: Serge Semin <fancer.lancer@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
	Brad Larson <brad@pensando.io>,
	linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
	linus.walleij@linaro.org, bgolaszewski@baylibre.com,
	broonie@kernel.org, adrian.hunter@intel.com,
	ulf.hansson@linaro.org, olof@lixom.net, dac2@pensando.io,
	linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org,
	linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/11] dt-bindings: spi: dw: Add Pensando Elba SoC SPI Controller bindings
Date: Tue, 12 Apr 2022 00:17:47 +0300	[thread overview]
Message-ID: <20220411211747.ttpqk7s37j3gpzxp@mobilestation> (raw)
In-Reply-To: <6769ea2d-9e6a-03b1-0e05-cb5b7379cb5e@linaro.org>

On Thu, Apr 07, 2022 at 08:52:34PM +0200, Krzysztof Kozlowski wrote:
> On 07/04/2022 01:36, Brad Larson wrote:
> > The Pensando Elba SoC has integrated the DW APB SPI Controller
> > and requires the property pensando,syscon-spics for access
> > to the spics control register.
> > 
> > Signed-off-by: Brad Larson <brad@pensando.io>
> > ---
> > Change from V3:
> > - Add required property pensando,syscon-spics to go with
> >   pensando,elba-spi
> 
> Thank you for your patch. There is something to discuss/improve.
> 
> 
> >  .../bindings/spi/snps,dw-apb-ssi.yaml           | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> > index d7e08b03e204..41c3bbf5a55c 100644
> > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> > @@ -37,6 +37,21 @@ allOf:
> >      else:
> >        required:
> >          - interrupts
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - pensando,elba-spi
> > +    then:
> > +      properties:
> > +        pensando,syscon-spics:
> > +          $ref: /schemas/types.yaml#/definitions/phandle
> > +          description:
> > +            Phandle to the system control device node which provides access to
> > +            the spics control register
> 

> It looks you only need to poke one register from spics, so it could be
> something like:
> 
>     items:
>       - items:
>           - description: Phandle to the system control device node
>           - description: spics control register offset

Right, especially seeing that's the way the elba-specific part of the
DW APB SSI driver expects the property being initialized.

-Sergey

> 
> 
> Best regards,
> Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel