From: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-amarula@amarulasolutions.com,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Joakim Zhang <qiangqing.zhang@nxp.com>, Li Jun <jun.li@nxp.com>,
Tim Harvey <tharvey@gateworks.com>,
Richard Zhu <hongxing.zhu@nxp.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: imx8mm-evk: add pwm1/backlight support
Date: Wed, 13 Apr 2022 16:06:32 +0200 [thread overview]
Message-ID: <20220413140632.GC4713@tom-ThinkPad-T14s-Gen-2i> (raw)
In-Reply-To: <8283132d-c271-d1b8-cb28-8f95305b11ec@linaro.org>
On Wed, Apr 13, 2022 at 03:45:44PM +0200, Krzysztof Kozlowski wrote:
> On 13/04/2022 14:56, Tommaso Merciai wrote:
> > Add pwm1/backlight support nodes for imx8mm_evk board.
> > Align with u-boot dts
> >
>
> Thank you for your patch. There is something to discuss/improve.
>
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > index 6d67df7692f1..4c18f8fcd377 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > @@ -59,6 +59,15 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
> > enable-active-high;
> > };
> >
> > + backlight: backlight {
> > + status = "okay";
>
> All nodes have status=okay by default, so no need for this.
>
> > + compatible = "pwm-backlight";
> > + pwms = <&pwm1 0 5000000>;
> > + brightness-levels = <0 255>;
> > + num-interpolated-steps = <255>;
> > + default-brightness-level = <250>;
> > + };
> > +
> > ir-receiver {
> > compatible = "gpio-ir-receiver";
> > gpios = <&gpio1 13 GPIO_ACTIVE_LOW>;
> > @@ -395,6 +404,12 @@ &wdog1 {
> > status = "okay";
> > };
> >
> > +&pwm1 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_backlight>;
> > + status = "okay";
>
> This is needed if the node was disabled in DTSI (I did not check it).
>
>
> Best regards,
> Krzysztof
Hi Krzysztof,
Thanks for review, I'll update in v3.
Regards,
Tommaso
--
Tommaso Merciai
Embedded Linux Engineer
tommaso.merciai@amarulasolutions.com
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@amarulasolutions.com
www.amarulasolutions.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-04-13 14:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 12:56 [PATCH v2] arm64: dts: imx8mm-evk: add pwm1/backlight support Tommaso Merciai
2022-04-13 13:45 ` Krzysztof Kozlowski
2022-04-13 14:06 ` Tommaso Merciai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220413140632.GC4713@tom-ThinkPad-T14s-Gen-2i \
--to=tommaso.merciai@amarulasolutions.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hongxing.zhu@nxp.com \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox