public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	kernel@collabora.com,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Tinghan Shen <tinghan.shen@mediatek.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: remoteproc: mediatek: Make l1tcm reg exclusive to mt819x
Date: Mon, 9 May 2022 11:05:17 -0400	[thread overview]
Message-ID: <20220509150517.ij5lev2mlcem2epx@notapiano> (raw)
In-Reply-To: <CA+Px+wXQjys8xvTSSJkLXoGp4yQnANbKWBtfuxiYi0UX6DH0jw@mail.gmail.com>

On Mon, May 09, 2022 at 10:27:18AM +0800, Tzung-Bi Shih wrote:
> On Sat, May 7, 2022 at 5:32 AM Nícolas F. R. A. Prado
> <nfraprado@collabora.com> wrote:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          enum:
> > +            - mediatek,mt8192-scp
> > +            - mediatek,mt8195-scp
> > +    then:
> > +      properties:
> > +        reg:
> > +          minItems: 3
> > +          maxItems: 3
> > +        reg-names:
> > +          items:
> > +            - const: sram
> > +            - const: cfg
> > +            - const: l1tcm
> 
> "l1tcm" should be optional.  Does it make more sense by using "minItems: 2"?

Hi Tzung-Bi,

thank you for the information. I did notice from the driver code that l1tcm was
treated as optional for mt8192, but since I wasn't sure if that was intended, I
kept it as required for the mt8192/mt8195 binding, since making it optional
later wouldn't break the ABI, but the opposite would.

But yes, since it is indeed optional for those platforms, I will lower minItems
to 2 for them in the next version.

Thanks,
Nícolas

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-05-09 15:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-06 21:32 [PATCH v4 0/2] Mediatek SCP dt-binding tweaks Nícolas F. R. A. Prado
2022-05-06 21:32 ` [PATCH v4 1/2] dt-bindings: remoteproc: mediatek: Make l1tcm reg exclusive to mt819x Nícolas F. R. A. Prado
2022-05-07 16:33   ` Krzysztof Kozlowski
2022-05-10 16:50     ` Nícolas F. R. A. Prado
2022-05-11  9:12       ` Krzysztof Kozlowski
2022-05-11  9:14         ` Krzysztof Kozlowski
2022-05-11 19:58         ` Nícolas F. R. A. Prado
2022-05-09  2:27   ` Tzung-Bi Shih
2022-05-09 15:05     ` Nícolas F. R. A. Prado [this message]
2022-05-06 21:32 ` [PATCH v4 2/2] dt-bindings: remoteproc: mediatek: Add optional memory-region to mtk, scp Nícolas F. R. A. Prado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220509150517.ij5lev2mlcem2epx@notapiano \
    --to=nfraprado@collabora.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@collabora.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=tinghan.shen@mediatek.com \
    --cc=tzungbi@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox