From: Nishanth Menon <nm@ti.com>
To: Rahul T R <r-ravikumar@ti.com>
Cc: devicetree@vger.kernel.org, vigneshr@ti.com, kristo@kernel.org,
linux-kernel@vger.kernel.org, kishon@ti.com, rogerq@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
Vijay Pothukuchi <vijayp@ti.com>,
lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/3] arm64: dts: ti: k3-j721e-*: Add dts nodes for EHRPWMs
Date: Fri, 17 Jun 2022 21:19:49 -0500 [thread overview]
Message-ID: <20220618021949.i5m4saxi2celzanz@kahuna> (raw)
In-Reply-To: <20220530101031.11357-3-r-ravikumar@ti.com>
On 15:40-20220530, Rahul T R wrote:
> From: Vijay Pothukuchi <vijayp@ti.com>
>
> Add dts nodes for 6 EHRPWM instances on SoC
>
> Signed-off-by: Vijay Pothukuchi <vijayp@ti.com>
> Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> ---
> .../dts/ti/k3-j721e-common-proc-board.dts | 24 +++++++
> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 62 ++++++++++++++++++-
> arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 24 +++++++
> 3 files changed, 109 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> index 2bc26a296496..f7d02fa4d6fc 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> @@ -995,3 +995,27 @@
> &main_mcan13 {
> status = "disabled";
> };
> +
> +&main_ehrpwm0 {
> + status = "disabled";
> +};
> +
> +&main_ehrpwm1 {
> + status = "disabled";
> +};
> +
> +&main_ehrpwm2 {
> + status = "disabled";
> +};
> +
> +&main_ehrpwm3 {
> + status = "disabled";
> +};
> +
> +&main_ehrpwm4 {
> + status = "disabled";
> +};
> +
> +&main_ehrpwm5 {
> + status = "disabled";
> +};
Do the pwm driver croak and die OR it is un-usable on proc-board or
disabled due to not-primary function (ideally drivers should shut things
off when unused)?
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> index 43b6cf5791ee..1ee00b73905d 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> @@ -66,7 +66,67 @@
> #mux-control-cells = <1>;
> mux-reg-masks = <0x4000 0x8000000>, /* USB0 to SERDES0/3 mux */
> <0x4010 0x8000000>; /* USB1 to SERDES1/2 mux */
> - };
> + };
> +
> + ehrpwm_tbclk: clock-controller@4140 {
> + compatible = "ti,am654-ehrpwm-tbclk", "syscon";
> + reg = <0x4140 0x18>;
> + #clock-cells = <1>;
> + };
> + };
> +
> + main_ehrpwm0: pwm@3000000 {
> + compatible = "ti,am654-ehrpwm", "ti,am3352-ehrpwm";
> + #pwm-cells = <3>;
> + reg = <0x0 0x3000000 0x0 0x100>;
would suggest 0x00 instead of 0x0
> + power-domains = <&k3_pds 83 TI_SCI_PD_EXCLUSIVE>;
> + clocks = <&ehrpwm_tbclk 0>, <&k3_clks 83 0>;
> + clock-names = "tbclk", "fck";
> + };
> +
> + main_ehrpwm1: pwm@3010000 {
> + compatible = "ti,am654-ehrpwm", "ti,am3352-ehrpwm";
> + #pwm-cells = <3>;
> + reg = <0x0 0x3010000 0x0 0x100>;
> + power-domains = <&k3_pds 84 TI_SCI_PD_EXCLUSIVE>;
> + clocks = <&ehrpwm_tbclk 1>, <&k3_clks 84 0>;
> + clock-names = "tbclk", "fck";
> + };
> +
> + main_ehrpwm2: pwm@3020000 {
> + compatible = "ti,am654-ehrpwm", "ti,am3352-ehrpwm";
> + #pwm-cells = <3>;
> + reg = <0x0 0x3020000 0x0 0x100>;
> + power-domains = <&k3_pds 85 TI_SCI_PD_EXCLUSIVE>;
> + clocks = <&ehrpwm_tbclk 2>, <&k3_clks 85 0>;
> + clock-names = "tbclk", "fck";
> + };
> +
> + main_ehrpwm3: pwm@3030000 {
> + compatible = "ti,am654-ehrpwm", "ti,am3352-ehrpwm";
> + #pwm-cells = <3>;
> + reg = <0x0 0x3030000 0x0 0x100>;
> + power-domains = <&k3_pds 86 TI_SCI_PD_EXCLUSIVE>;
> + clocks = <&ehrpwm_tbclk 3>, <&k3_clks 86 0>;
> + clock-names = "tbclk", "fck";
> + };
> +
> + main_ehrpwm4: pwm@3040000 {
> + compatible = "ti,am654-ehrpwm", "ti,am3352-ehrpwm";
> + #pwm-cells = <3>;
> + reg = <0x0 0x3040000 0x0 0x100>;
> + power-domains = <&k3_pds 87 TI_SCI_PD_EXCLUSIVE>;
> + clocks = <&ehrpwm_tbclk 4>, <&k3_clks 87 0>;
> + clock-names = "tbclk", "fck";
> + };
> +
> + main_ehrpwm5: pwm@3050000 {
> + compatible = "ti,am654-ehrpwm", "ti,am3352-ehrpwm";
> + #pwm-cells = <3>;
> + reg = <0x0 0x3050000 0x0 0x100>;
> + power-domains = <&k3_pds 88 TI_SCI_PD_EXCLUSIVE>;
> + clocks = <&ehrpwm_tbclk 5>, <&k3_clks 88 0>;
> + clock-names = "tbclk", "fck";
> };
>
> gic500: interrupt-controller@1800000 {
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> index 80358cba6954..98a55778f3fe 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> @@ -1129,3 +1129,27 @@
> memory-region = <&c71_0_dma_memory_region>,
> <&c71_0_memory_region>;
> };
> +
> +&main_ehrpwm0 {
> + status = "disabled";
> +};
> +
> +&main_ehrpwm1 {
> + status = "disabled";
> +};
> +
> +&main_ehrpwm2 {
> + status = "disabled";
> +};
> +
> +&main_ehrpwm3 {
> + status = "disabled";
> +};
> +
> +&main_ehrpwm4 {
> + status = "disabled";
> +};
> +
> +&main_ehrpwm5 {
> + status = "disabled";
> +};
> --
> 2.17.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-06-18 2:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220530101031.11357-1-r-ravikumar@ti.com>
[not found] ` <20220530101031.11357-2-r-ravikumar@ti.com>
2022-05-30 11:27 ` [PATCH v4 1/3] dt-bindings: mfd: ti,j721e-system-controller: Add clock property Krzysztof Kozlowski
2022-06-15 19:35 ` Lee Jones
[not found] ` <20220530101031.11357-4-r-ravikumar@ti.com>
2022-06-18 2:16 ` [PATCH v4 3/3] arm64: dts: ti: k3-j721e-sk: Add pinmux for RPi Header Nishanth Menon
2022-06-18 12:11 ` Jason Kridner
[not found] ` <20220530101031.11357-3-r-ravikumar@ti.com>
2022-06-18 2:19 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220618021949.i5m4saxi2celzanz@kahuna \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=r-ravikumar@ti.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=vigneshr@ti.com \
--cc=vijayp@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox