From: Nishanth Menon <nm@ti.com>
To: Yihao Han <hanyihao@vivo.com>
Cc: Santosh Shilimkar <ssantosh@kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <kernel@vivo.com>
Subject: Re: [PATCH] soc: ti: wkup_m3_ipc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
Date: Fri, 17 Jun 2022 21:40:48 -0500 [thread overview]
Message-ID: <20220618024048.hr7hgphogmdaeq2x@kahuna> (raw)
In-Reply-To: <20220505024833.8494-1-hanyihao@vivo.com>
On 19:48-20220504, Yihao Han wrote:
> Fix the following coccicheck warning:
> ./drivers/soc/ti/wkup_m3_ipc.c:198:0-23: WARNING:
> wkup_m3_ipc_option_fops should be defined with
> DEFINE_DEBUGFS_ATTRIBUTE
>
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---
> drivers/soc/ti/wkup_m3_ipc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 0076d467ff6b..2142d8fb3f5c 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -195,7 +195,7 @@ static int option_set(void *data, u64 val)
> return 0;
> }
>
> -DEFINE_SIMPLE_ATTRIBUTE(wkup_m3_ipc_option_fops, option_get, option_set,
> +DEFINE_DEBUGFS_ATTRIBUTE(wkup_m3_ipc_option_fops, option_get, option_set,
> "%llu\n");
Please run ./scripts/checkpatch --strict patch
+CHECK: Alignment should match open parenthesis
+#29: FILE: drivers/soc/ti/wkup_m3_ipc.c:199:
++DEFINE_DEBUGFS_ATTRIBUTE(wkup_m3_ipc_option_fops, option_get, option_set,
+ "%llu\n");
+ mechanically convert to the typical style using --fix or --fix-inplace.
+ them to the maintainer, see CHECKPATCH in MAINTAINERS.
Could you fix and post a V2?
>
> static int wkup_m3_ipc_dbg_init(struct wkup_m3_ipc *m3_ipc)
> --
> 2.17.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-06-18 2:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 2:48 [PATCH] soc: ti: wkup_m3_ipc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE Yihao Han
2022-06-18 2:40 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220618024048.hr7hgphogmdaeq2x@kahuna \
--to=nm@ti.com \
--cc=hanyihao@vivo.com \
--cc=kernel@vivo.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox