From: Bjorn Helgaas <helgaas@kernel.org>
To: Jaehoon Chung <jh80.chung@samsung.com>,
Jingoo Han <jingoohan1@gmail.com>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: pci-exynos.c phy_init() usage
Date: Fri, 24 Jun 2022 12:35:41 -0500 [thread overview]
Message-ID: <20220624173541.GA1543581@bhelgaas> (raw)
In exynos_pcie_host_init() [1], we call:
phy_reset(ep->phy);
phy_power_on(ep->phy);
phy_init(ep->phy);
The phy_init() function comment [2] says it must be called before
phy_power_on(). Is exynos doing this backwards?
Bjorn
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/controller/dwc/pci-exynos.c?id=v5.19-rc1#n252
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/phy-core.c?id=v5.19-rc1#n233
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2022-06-24 17:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 17:35 Bjorn Helgaas [this message]
2022-06-24 18:07 ` pci-exynos.c phy_init() usage Krzysztof Kozlowski
2022-06-27 10:30 ` Marek Szyprowski
2022-06-27 10:47 ` Krzysztof Kozlowski
2022-06-28 8:13 ` Marek Szyprowski
2022-06-28 8:27 ` Krzysztof Kozlowski
2022-06-28 10:59 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624173541.GA1543581@bhelgaas \
--to=helgaas@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox