* [PATCH] iio: adc: at91-sama5d2_adc: get rid of 5 degrees Celsius adjustment
@ 2022-10-20 10:27 Claudiu Beznea
2022-10-23 12:21 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Claudiu Beznea @ 2022-10-20 10:27 UTC (permalink / raw)
To: eugen.hristev, jic23, lars, nicolas.ferre, alexandre.belloni
Cc: linux-iio, linux-arm-kernel, linux-kernel, Claudiu Beznea
On SAMA7G5 final chip version there is no need for 5 degrees Celsius
adjustment when computing junction temperature, thus, remove it.
Fixes: 5ab38b81895c ("iio: adc: at91-sama5d2_adc: add support for temperature sensor")
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
drivers/iio/adc/at91-sama5d2_adc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
index 33e251552214..870f4cb60923 100644
--- a/drivers/iio/adc/at91-sama5d2_adc.c
+++ b/drivers/iio/adc/at91-sama5d2_adc.c
@@ -2307,11 +2307,9 @@ static int at91_adc_temp_sensor_init(struct at91_adc_state *st,
clb->p6 = buf[AT91_ADC_TS_CLB_IDX_P6];
/*
- * We prepare here the conversion to milli and also add constant
- * factor (5 degrees Celsius) to p1 here to avoid doing it on
- * hotpath.
+ * We prepare here the conversion to milli to avoid doing it on hotpath.
*/
- clb->p1 = clb->p1 * 1000 + 5000;
+ clb->p1 = clb->p1 * 1000;
free_buf:
kfree(buf);
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: adc: at91-sama5d2_adc: get rid of 5 degrees Celsius adjustment
2022-10-20 10:27 [PATCH] iio: adc: at91-sama5d2_adc: get rid of 5 degrees Celsius adjustment Claudiu Beznea
@ 2022-10-23 12:21 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2022-10-23 12:21 UTC (permalink / raw)
To: Claudiu Beznea
Cc: alexandre.belloni, lars, linux-iio, linux-kernel, eugen.hristev,
linux-arm-kernel
On Thu, 20 Oct 2022 13:27:05 +0300
Claudiu Beznea <claudiu.beznea@microchip.com> wrote:
> On SAMA7G5 final chip version there is no need for 5 degrees Celsius
> adjustment when computing junction temperature, thus, remove it.
>
> Fixes: 5ab38b81895c ("iio: adc: at91-sama5d2_adc: add support for temperature sensor")
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Applied to the fixes-togreg branch of iio.git
Thanks,
Jonathan
> ---
> drivers/iio/adc/at91-sama5d2_adc.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
> index 33e251552214..870f4cb60923 100644
> --- a/drivers/iio/adc/at91-sama5d2_adc.c
> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
> @@ -2307,11 +2307,9 @@ static int at91_adc_temp_sensor_init(struct at91_adc_state *st,
> clb->p6 = buf[AT91_ADC_TS_CLB_IDX_P6];
>
> /*
> - * We prepare here the conversion to milli and also add constant
> - * factor (5 degrees Celsius) to p1 here to avoid doing it on
> - * hotpath.
> + * We prepare here the conversion to milli to avoid doing it on hotpath.
> */
> - clb->p1 = clb->p1 * 1000 + 5000;
> + clb->p1 = clb->p1 * 1000;
>
> free_buf:
> kfree(buf);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-23 12:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-20 10:27 [PATCH] iio: adc: at91-sama5d2_adc: get rid of 5 degrees Celsius adjustment Claudiu Beznea
2022-10-23 12:21 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox