From: Dafna Hirschfeld <dafna@fastmail.com>
To: Paul Elder <paul.elder@ideasonboard.com>
Cc: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] media: rkisp1: Add NV16M and NV61M to output formats
Date: Sat, 19 Nov 2022 12:59:22 +0200 [thread overview]
Message-ID: <20221119105922.ktgpadbhhb4wsild@guri> (raw)
In-Reply-To: <20221117084217.3892680-2-paul.elder@ideasonboard.com>
On 17.11.2022 17:42, Paul Elder wrote:
>Add support for NV16M and NV61M as output formats. As NV16, NV61, NV12M
>and NV21M are already supported, the infrastructure is already in place
>to support NV16M and NV61M, so it is sufficient to simply add relevant
>entries to the list of output formats.
>
>Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
>Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Dafna Hirschfeld <dafna@fastmail.com>
>---
> .../platform/rockchip/rkisp1/rkisp1-capture.c | 22 +++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
>diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
>index d4540684ea9a..7695ef134908 100644
>--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
>+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
>@@ -110,6 +110,16 @@ static const struct rkisp1_capture_fmt_cfg rkisp1_mp_fmts[] = {
> .uv_swap = 1,
> .write_format = RKISP1_MI_CTRL_MP_WRITE_YUV_SPLA,
> .mbus = MEDIA_BUS_FMT_YUYV8_2X8,
>+ }, {
>+ .fourcc = V4L2_PIX_FMT_NV16M,
>+ .uv_swap = 0,
>+ .write_format = RKISP1_MI_CTRL_MP_WRITE_YUV_SPLA,
>+ .mbus = MEDIA_BUS_FMT_YUYV8_2X8,
>+ }, {
>+ .fourcc = V4L2_PIX_FMT_NV61M,
>+ .uv_swap = 1,
>+ .write_format = RKISP1_MI_CTRL_MP_WRITE_YUV_SPLA,
>+ .mbus = MEDIA_BUS_FMT_YUYV8_2X8,
> }, {
> .fourcc = V4L2_PIX_FMT_YVU422M,
> .uv_swap = 1,
>@@ -237,6 +247,18 @@ static const struct rkisp1_capture_fmt_cfg rkisp1_sp_fmts[] = {
> .write_format = RKISP1_MI_CTRL_SP_WRITE_SPLA,
> .output_format = RKISP1_MI_CTRL_SP_OUTPUT_YUV422,
> .mbus = MEDIA_BUS_FMT_YUYV8_2X8,
>+ }, {
>+ .fourcc = V4L2_PIX_FMT_NV16M,
>+ .uv_swap = 0,
>+ .write_format = RKISP1_MI_CTRL_SP_WRITE_SPLA,
>+ .output_format = RKISP1_MI_CTRL_SP_OUTPUT_YUV422,
>+ .mbus = MEDIA_BUS_FMT_YUYV8_2X8,
>+ }, {
>+ .fourcc = V4L2_PIX_FMT_NV61M,
>+ .uv_swap = 1,
>+ .write_format = RKISP1_MI_CTRL_SP_WRITE_SPLA,
>+ .output_format = RKISP1_MI_CTRL_SP_OUTPUT_YUV422,
>+ .mbus = MEDIA_BUS_FMT_YUYV8_2X8,
> }, {
> .fourcc = V4L2_PIX_FMT_YVU422M,
> .uv_swap = 1,
>--
>2.35.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-19 11:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 8:42 [PATCH v2 0/3] media: rkisp1: Miscellaneous improvements Paul Elder
2022-11-17 8:42 ` [PATCH v2 1/3] media: rkisp1: Add NV16M and NV61M to output formats Paul Elder
2022-11-19 10:59 ` Dafna Hirschfeld [this message]
2022-11-17 8:42 ` [PATCH v2 2/3] media: rkisp1: Make local immutable array variables static const Paul Elder
2022-11-19 22:28 ` Laurent Pinchart
2023-01-26 23:28 ` Laurent Pinchart
2023-03-24 10:37 ` Jacopo Mondi
2023-03-25 19:24 ` Laurent Pinchart
2022-11-17 8:42 ` [PATCH v2 3/3] media: rkisp1: Implement ENUM_FRAMESIZES Paul Elder
2022-11-19 10:57 ` Dafna Hirschfeld
2023-02-21 13:57 ` [PATCH v2 0/3] media: rkisp1: Miscellaneous improvements Jacopo Mondi
2023-03-25 20:00 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221119105922.ktgpadbhhb4wsild@guri \
--to=dafna@fastmail.com \
--cc=heiko@sntech.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=paul.elder@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox