From: Dafna Hirschfeld <dafna@fastmail.com>
To: Paul Elder <paul.elder@ideasonboard.com>
Cc: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] media: rkisp1: Implement ENUM_FRAMESIZES
Date: Sat, 19 Nov 2022 12:57:14 +0200 [thread overview]
Message-ID: <20221119105714.6ynnl2jvfwnb4flw@guri> (raw)
In-Reply-To: <20221117084217.3892680-4-paul.elder@ideasonboard.com>
On 17.11.2022 17:42, Paul Elder wrote:
>Implement VIDIOC_ENUM_FRAMESIZES for the rkisp1 capture devices.
>
>Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
>Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Dafna Hirschfeld <dafna@fastmail.com>
>---
> .../platform/rockchip/rkisp1/rkisp1-capture.c | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
>diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
>index 91e685fdbbe9..03c2922bfbed 100644
>--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
>+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
>@@ -1236,6 +1236,35 @@ static int rkisp1_enum_fmt_vid_cap_mplane(struct file *file, void *priv,
> return -EINVAL;
> }
>
>+static int rkisp1_enum_framesizes(struct file *file, void *fh,
>+ struct v4l2_frmsizeenum *fsize)
>+{
>+ static const unsigned int max_widths[] = {
>+ RKISP1_RSZ_MP_SRC_MAX_WIDTH,
>+ RKISP1_RSZ_SP_SRC_MAX_WIDTH,
>+ };
>+ static const unsigned int max_heights[] = {
>+ RKISP1_RSZ_MP_SRC_MAX_HEIGHT,
>+ RKISP1_RSZ_SP_SRC_MAX_HEIGHT,
>+ };
>+ struct rkisp1_capture *cap = video_drvdata(file);
>+
>+ if (fsize->index != 0)
>+ return -EINVAL;
>+
>+ fsize->type = V4L2_FRMSIZE_TYPE_STEPWISE;
>+
>+ fsize->stepwise.min_width = RKISP1_RSZ_SRC_MIN_WIDTH;
>+ fsize->stepwise.max_width = max_widths[cap->id];
>+ fsize->stepwise.step_width = 2;
>+
>+ fsize->stepwise.min_height = RKISP1_RSZ_SRC_MIN_HEIGHT;
>+ fsize->stepwise.max_height = max_heights[cap->id];
>+ fsize->stepwise.step_height = 2;
>+
>+ return 0;
>+}
>+
> static int rkisp1_s_fmt_vid_cap_mplane(struct file *file,
> void *priv, struct v4l2_format *f)
> {
>@@ -1285,6 +1314,7 @@ static const struct v4l2_ioctl_ops rkisp1_v4l2_ioctl_ops = {
> .vidioc_s_fmt_vid_cap_mplane = rkisp1_s_fmt_vid_cap_mplane,
> .vidioc_g_fmt_vid_cap_mplane = rkisp1_g_fmt_vid_cap_mplane,
> .vidioc_enum_fmt_vid_cap = rkisp1_enum_fmt_vid_cap_mplane,
>+ .vidioc_enum_framesizes = rkisp1_enum_framesizes,
> .vidioc_querycap = rkisp1_querycap,
> .vidioc_subscribe_event = v4l2_ctrl_subscribe_event,
> .vidioc_unsubscribe_event = v4l2_event_unsubscribe,
>--
>2.35.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-19 10:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 8:42 [PATCH v2 0/3] media: rkisp1: Miscellaneous improvements Paul Elder
2022-11-17 8:42 ` [PATCH v2 1/3] media: rkisp1: Add NV16M and NV61M to output formats Paul Elder
2022-11-19 10:59 ` Dafna Hirschfeld
2022-11-17 8:42 ` [PATCH v2 2/3] media: rkisp1: Make local immutable array variables static const Paul Elder
2022-11-19 22:28 ` Laurent Pinchart
2023-01-26 23:28 ` Laurent Pinchart
2023-03-24 10:37 ` Jacopo Mondi
2023-03-25 19:24 ` Laurent Pinchart
2022-11-17 8:42 ` [PATCH v2 3/3] media: rkisp1: Implement ENUM_FRAMESIZES Paul Elder
2022-11-19 10:57 ` Dafna Hirschfeld [this message]
2023-02-21 13:57 ` [PATCH v2 0/3] media: rkisp1: Miscellaneous improvements Jacopo Mondi
2023-03-25 20:00 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221119105714.6ynnl2jvfwnb4flw@guri \
--to=dafna@fastmail.com \
--cc=heiko@sntech.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=paul.elder@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox