From: Steven Rostedt <rostedt@goodmis.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
will@kernel.org
Subject: Re: [PATCH] ftrace: arm64: remove static ftrace
Date: Tue, 22 Nov 2022 12:04:30 -0500 [thread overview]
Message-ID: <20221122120430.6932d29c@gandalf.local.home> (raw)
In-Reply-To: <20221122163624.1225912-1-mark.rutland@arm.com>
On Tue, 22 Nov 2022 16:36:24 +0000
Mark Rutland <mark.rutland@arm.com> wrote:
> The build test robot pointer out that there's a build failure when:
>
> CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS=y
> CONFIG_DYNAMIC_FTRACE_WITH_ARGS=n
>
> ... due to some mismatched ifdeffery, some of which checks
> CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS, and some of which checks
> CONFIG_DYNAMIC_FTRACE_WITH_ARGS, leading to some missing definitions expected
> by the core code when CONFIG_DYNAMIC_FTRACE=n and consequently
> CONFIG_DYNAMIC_FTRACE_WITH_ARGS=n.
>
> There's really not much point in supporting CONFIG_DYNAMIC_FTRACE=n (AKA
> static ftrace). All supported toolchains allow us to implement
> DYNAMIC_FTRACE, distributions all prefer DYNAMIC_FTRACE, and both
> powerpc and s390 removed support for static ftrace in commits:
>
> 0c0c52306f4792a4 ("powerpc: Only support DYNAMIC_FTRACE not static")
> 5d6a0163494c78ad ("s390/ftrace: enforce DYNAMIC_FTRACE if FUNCTION_TRACER is selected")
>
> ... and according to Steven, static ftrace is only supported on x86 to
> allow testing that the core code still functions in this configuration.
>
> Given that, let's simplify matters by removing arm64's support for
> static ftrace. This avoids the problem originally reported, and leaves
> us with less code to maintain.
>
> Fixes: 26299b3f6ba26bfc ("ftrace: arm64: move from REGS to ARGS")
> Link: https://lore.kernel.org/r/202211212249.livTPi3Y-lkp@intel.com
> Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-22 17:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 16:36 [PATCH] ftrace: arm64: remove static ftrace Mark Rutland
2022-11-22 17:04 ` Steven Rostedt [this message]
2022-11-25 13:24 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122120430.6932d29c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox