public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: 王洪辉 <honghui.wang@ucas.com.cn>
Cc: Cristian Maruss <cristian.marussi@arm.com>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Re：Re: [PATCH 3/3] arm_scpi: modify to support acpi
Date: Thu, 24 Nov 2022 11:57:07 +0000	[thread overview]
Message-ID: <20221124115707.e5hsb5we25rzstv6@bogus> (raw)
In-Reply-To: <tencent_6578975367ED7DB20B7903C3@qq.com>

Hi Wang,


Please use text for your emails. I think it is html and I can't read it.

On Thu, Nov 24, 2022 at 07:17:32PM +0800, 王洪辉 wrote:
> For&nbsp;ARM64,&nbsp;If&nbsp;boot&nbsp;from&nbsp;uefi,&nbsp;SCPI&nbsp;driver&nbsp;should&nbsp;support&nbsp;ACPI&nbsp;to&nbsp;show&nbsp;CPU&nbsp;temp&nbsp;&amp;&nbsp;freq,&nbsp;This&nbsp;patch&nbsp;is&nbsp;for&nbsp;the&nbsp;case,&nbsp;I&nbsp;had&nbsp;test&nbsp;ok&nbsp;on&nbsp;Phytium&nbsp;FT2000/4&nbsp;plantform.&nbsp;And&nbsp;please&nbsp;append&nbsp;Patch&nbsp;V2&nbsp;3/3.
> 
> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;---原始邮件---
> 发件人:&quot;Sudeep&nbsp;Holla&quot;<sudeep.holla@arm.com&gt;
> 发送时间:2022年11月24日(星期四)&nbsp;晚上7:10
> 收件人:&quot;Wang&nbsp;Honghui&quot;<honghui.wang@ucas.com.cn&gt;;
> 主题:&nbsp;[PATCH&nbsp;3/3]&nbsp;arm_scpi:&nbsp;modify&nbsp;to&nbsp;support&nbsp;acpi
> Hi&nbsp;W&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
> ------------------&nbsp;Original&nbsp;------------------
> From:&nbsp;&quot;Sudeep Holla&quot;<sudeep.holla@arm.com&gt;
> Date:&nbsp;Thu, Nov 24, 2022 07:10 PM
> To:&nbsp;&quot;Wang Honghui&quot;<honghui.wang@ucas.com.cn&gt;;
> Cc:&nbsp;&quot;Cristian Maruss&quot;<cristian.marussi@arm.com&gt;;&quot;Jassi Brar&quot;<jassisinghbrar@gmail.com&gt;;&quot;Sudeep Holla&quot;<sudeep.holla@arm.com&gt;;&quot;linux-arm-kernel&quot;<linux-arm-kernel@lists.infradead.org&gt;;&quot;linux-kernel&quot;<linux-kernel@vger.kernel.org&gt;;
> Subject:&nbsp;Re: [PATCH 3/3] arm_scpi: modify to support acpi

Doing %s/&nbsp;/ /g gave me:

> For ARM64, If boot from uefi, SCPI driver should support ACPI to show CPU
> temp &amp; freq, This patch is for the case, I had test ok on Phytium
> FT2000/4 plantform. And please append Patch V2 3/3.

Let me repeat. You must use PCC driver without any phytium ft2000/4 platform
code. All platform specific code and SCPI protocol must be hidden/abstracted
in ACPI AML.

Your changes are not acceptable for upstream. No change will be allowed in
SCPI for ACPI as it needs to go in the firmware tables.

Also I noticed drivers/mailbox/phytium_mailbox.c doesn't exist. So this patch
is wrong in so many ways. Please check on how to represent phytium_mailbox
hardware using ACPI PCC and add AML code that uses SCPI to achieve whatever
you want. You may want to check on how to use PCC OpRegion as well in ACPI.

-- 
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

       reply	other threads:[~2022-11-24 11:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tencent_6578975367ED7DB20B7903C3@qq.com>
2022-11-24 11:57 ` Sudeep Holla [this message]
2022-11-24 14:17 =?gb18030?B?UmWjulJlOiBbUEFUQ0ggMy8zXSBhcm1fc2NwaTogbW9kaWZ5IHRvIHN1cHBvcnQgYWNwaQ==?= =?gb18030?B?zfW66bvU?=
2022-11-25  1:38 ` Re：Re: [PATCH 3/3] arm_scpi: modify to support acpi Hanjun Guo
2022-11-25  9:54   ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221124115707.e5hsb5we25rzstv6@bogus \
    --to=sudeep.holla@arm.com \
    --cc=cristian.marussi@arm.com \
    --cc=honghui.wang@ucas.com.cn \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox