From: Sudeep Holla <sudeep.holla@arm.com>
To: 王洪辉 <honghui.wang@ucas.com.cn>
Cc: Hanjun Guo <guohanjun@huawei.com>,
Mark Rutland <mark.rutland@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Cristian Maruss <cristian.marussi@arm.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Re：Re: [PATCH 3/3] arm_scpi: modify to support acpi
Date: Fri, 25 Nov 2022 09:54:38 +0000 [thread overview]
Message-ID: <20221125095438.o6li7xgib27x5nb7@bogus> (raw)
In-Reply-To: <9732f012-f2f5-d770-c9b7-6005fa0c578f@huawei.com>
On Fri, Nov 25, 2022 at 09:38:42AM +0800, Hanjun Guo wrote:
> Hi Honghui,
>
> On 2022/11/24 22:17, 锟斤拷锟斤拷锟? wrote:
> > Thanks!
> >
> > The uefi firmware was built include ACPI/AML, but current kernel code is
> > not able to extract the info, the ACPI/AML driver of kernel is not enough
> > for majority of devices , but fdt driver is. I think there's a lot of
> > work to support more acpi driver.
>
> I think the firmware did the wrong thing about SCPI support,
> please take a look at ACPI 6.5, chapter 14 Platform Communications
> Channel (PCC).
>
Thanks Hanjun for pin pointing the exact references in the ACPI spec.
Hi Wang,
You seemed to be posting random patches to add SCPI support in ACPI.
You will get a NACK on all unless you explore PCC and PCC OpRegion in
ACPI and update your firmware to make it work on your platform.
You had sent a patch updating the mailbox driver which is not present
in the upstream. You must not need that driver when you use PCCT in
the ACPI firmware, so please drop the driver and any changes to that
as well. Without seeing the actual driver you are using with SCPI, I
can't help much on how to use it with PCC. Please refer chapter 14 as
Hanjun mention and check how to write one to your platform. Think
PCCT as mailbox node equivalent in DT and you *must not* just add similar
node in your ACPI DSDT with some custom HID/CID.
Hope this helps and gives you better idea on the suggestions made so far.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-25 10:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 14:17 =?gb18030?B?UmWjulJlOiBbUEFUQ0ggMy8zXSBhcm1fc2NwaTogbW9kaWZ5IHRvIHN1cHBvcnQgYWNwaQ==?= =?gb18030?B?zfW66bvU?=
2022-11-25 1:38 ` Re：Re: [PATCH 3/3] arm_scpi: modify to support acpi Hanjun Guo
2022-11-25 9:54 ` Sudeep Holla [this message]
[not found] <tencent_6578975367ED7DB20B7903C3@qq.com>
2022-11-24 11:57 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221125095438.o6li7xgib27x5nb7@bogus \
--to=sudeep.holla@arm.com \
--cc=cristian.marussi@arm.com \
--cc=guohanjun@huawei.com \
--cc=honghui.wang@ucas.com.cn \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox