* [PATCH] PCI: xilinx-nwl: Fix coding style violations
@ 2022-12-08 12:38 Michal Simek
2022-12-08 16:52 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Michal Simek @ 2022-12-08 12:38 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git
Cc: Bjorn Helgaas, Krzysztof Wilczyński, Lorenzo Pieralisi,
Rob Herring, linux-arm-kernel, linux-pci
Fix code alignments and remove additional newline.
Signed-off-by: Michal Simek <michal.simek@amd.com>
---
We have this in our tree for a while. It is just coding style change which
is fine. Let's see if you accept it. If not I will revert it on our side.
Thanks,
Michal
---
drivers/pci/controller/pcie-xilinx-nwl.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/controller/pcie-xilinx-nwl.c b/drivers/pci/controller/pcie-xilinx-nwl.c
index 40d070e54ad2..e10a58649bf5 100644
--- a/drivers/pci/controller/pcie-xilinx-nwl.c
+++ b/drivers/pci/controller/pcie-xilinx-nwl.c
@@ -474,15 +474,15 @@ static int nwl_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,
for (i = 0; i < nr_irqs; i++) {
irq_domain_set_info(domain, virq + i, bit + i, &nwl_irq_chip,
- domain->host_data, handle_simple_irq,
- NULL, NULL);
+ domain->host_data, handle_simple_irq,
+ NULL, NULL);
}
mutex_unlock(&msi->lock);
return 0;
}
static void nwl_irq_domain_free(struct irq_domain *domain, unsigned int virq,
- unsigned int nr_irqs)
+ unsigned int nr_irqs)
{
struct irq_data *data = irq_domain_get_irq_data(domain, virq);
struct nwl_pcie *pcie = irq_data_get_irq_chip_data(data);
@@ -722,7 +722,6 @@ static int nwl_pcie_bridge_init(struct nwl_pcie *pcie)
/* Enable all misc interrupts */
nwl_bridge_writel(pcie, MSGF_MISC_SR_MASKALL, MSGF_MISC_MASK);
-
/* Disable all legacy interrupts */
nwl_bridge_writel(pcie, (u32)~MSGF_LEG_SR_MASKALL, MSGF_LEG_MASK);
--
2.36.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] PCI: xilinx-nwl: Fix coding style violations
2022-12-08 12:38 [PATCH] PCI: xilinx-nwl: Fix coding style violations Michal Simek
@ 2022-12-08 16:52 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2022-12-08 16:52 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, monstr, michal.simek, git, Bjorn Helgaas,
Krzysztof Wilczyński, Lorenzo Pieralisi, Rob Herring,
linux-arm-kernel, linux-pci
On Thu, Dec 08, 2022 at 01:38:50PM +0100, Michal Simek wrote:
> Fix code alignments and remove additional newline.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
Since we're up against the merge window, I applied this directly to
pci/ctrl/xilinx for v6.2, thanks!
> ---
> drivers/pci/controller/pcie-xilinx-nwl.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-xilinx-nwl.c b/drivers/pci/controller/pcie-xilinx-nwl.c
> index 40d070e54ad2..e10a58649bf5 100644
> --- a/drivers/pci/controller/pcie-xilinx-nwl.c
> +++ b/drivers/pci/controller/pcie-xilinx-nwl.c
> @@ -474,15 +474,15 @@ static int nwl_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,
>
> for (i = 0; i < nr_irqs; i++) {
> irq_domain_set_info(domain, virq + i, bit + i, &nwl_irq_chip,
> - domain->host_data, handle_simple_irq,
> - NULL, NULL);
> + domain->host_data, handle_simple_irq,
> + NULL, NULL);
> }
> mutex_unlock(&msi->lock);
> return 0;
> }
>
> static void nwl_irq_domain_free(struct irq_domain *domain, unsigned int virq,
> - unsigned int nr_irqs)
> + unsigned int nr_irqs)
> {
> struct irq_data *data = irq_domain_get_irq_data(domain, virq);
> struct nwl_pcie *pcie = irq_data_get_irq_chip_data(data);
> @@ -722,7 +722,6 @@ static int nwl_pcie_bridge_init(struct nwl_pcie *pcie)
> /* Enable all misc interrupts */
> nwl_bridge_writel(pcie, MSGF_MISC_SR_MASKALL, MSGF_MISC_MASK);
>
> -
> /* Disable all legacy interrupts */
> nwl_bridge_writel(pcie, (u32)~MSGF_LEG_SR_MASKALL, MSGF_LEG_MASK);
>
> --
> 2.36.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-08 16:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-08 12:38 [PATCH] PCI: xilinx-nwl: Fix coding style violations Michal Simek
2022-12-08 16:52 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox