Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Ravi Gunasekaran <r-gunasekaran@ti.com>
Cc: <afd@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>,
	<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<s-vadapalli@ti.com>, <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v10 2/9] arm64: dts: ti: k3-j721s2-main: Add support for USB
Date: Wed, 22 Feb 2023 07:15:59 -0600	[thread overview]
Message-ID: <20230222131559.day4frfvjuje25i4@suffrage> (raw)
In-Reply-To: <a74bf007-40b5-3d92-ba30-c50a2bf4a3c0@ti.com>

On 10:21-20230222, Ravi Gunasekaran wrote:
[...]
> >> +	usbss0: cdns-usb@4104000 {
> >> +		compatible = "ti,j721e-usb";
> >> +		reg = <0x00 0x04104000 0x00 0x100>;
> >> +		clocks = <&k3_clks 360 16>, <&k3_clks 360 15>;
> >> +		clock-names = "ref", "lpm";
> >> +		assigned-clocks = <&k3_clks 360 16>; /* USB2_REFCLK */
> >> +		assigned-clock-parents = <&k3_clks 360 17>;
> >> +		power-domains = <&k3_pds 360 TI_SCI_PD_EXCLUSIVE>;
> >> +		#address-cells = <2>;
> >> +		#size-cells = <2>;
> >> +		ranges;
> >> +		dma-coherent;
> >> +
> >> +		status = "disabled";
> > 
> > Why disabled by default?
> 
> One of the comment received in the v9 series was to disable the node in
> the include file and then enable it in the board specific DTS file.
> Changes in this series addressed that comment.

Document in the node why it is disabled by default. Also do make sure
All K3 SoCs dtsi nodes follow the same argument.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-02-22 13:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 12:06 [PATCH v10 0/9] arm64: j721s2: Add support for additional IPs Ravi Gunasekaran
2023-02-21 12:06 ` [PATCH v10 1/9] dt-bindings: mfd: ti,j721e-system-controller: Fix mux node regex Ravi Gunasekaran
2023-02-21 13:41   ` Nishanth Menon
2023-02-22  4:33     ` Ravi Gunasekaran
2023-02-21 13:59   ` Vignesh Raghavendra
2023-02-21 17:04     ` Rob Herring
2023-02-22  4:38       ` [EXTERNAL] Re: [PATCH v10 1/9] dt-bindings: mfd: ti, j721e-system-controller: " Ravi Gunasekaran
2023-02-22  4:35     ` [PATCH v10 1/9] dt-bindings: mfd: ti,j721e-system-controller: " Ravi Gunasekaran
2023-02-21 12:06 ` [PATCH v10 2/9] arm64: dts: ti: k3-j721s2-main: Add support for USB Ravi Gunasekaran
2023-02-21 13:58   ` Nishanth Menon
2023-02-22  4:51     ` Ravi Gunasekaran
2023-02-22 13:15       ` Nishanth Menon [this message]
2023-02-21 12:06 ` [PATCH v10 3/9] arm64: dts: ti: k3-j721s2-main: Add SERDES and WIZ device tree node Ravi Gunasekaran
2023-02-21 14:01   ` Nishanth Menon
2023-02-22  4:53     ` Ravi Gunasekaran
2023-02-21 12:06 ` [PATCH v10 4/9] arm64: dts: ti: k3-j721s2-mcu-wakeup: Add support of OSPI Ravi Gunasekaran
2023-02-21 12:06 ` [PATCH v10 5/9] arm64: dts: ti: k3-j721s2-common-proc-board: Enable SERDES0 Ravi Gunasekaran
2023-02-21 12:06 ` [PATCH v10 6/9] arm64: dts: ti: k3-j721s2-common-proc-board: Add USB support Ravi Gunasekaran
2023-02-21 12:06 ` [PATCH v10 7/9] arm64: dts: ti: k3-j721s2: Add support for OSPI Flashes Ravi Gunasekaran
2023-02-21 12:06 ` [PATCH v10 8/9] arm64: dts: ti: k3-j721s2-main: Add PCIe device tree node Ravi Gunasekaran
2023-02-21 12:06 ` [PATCH v10 9/9] arm64: dts: ti: k3-j721s2-common-proc-board: Enable PCIe Ravi Gunasekaran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230222131559.day4frfvjuje25i4@suffrage \
    --to=nm@ti.com \
    --cc=afd@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=r-gunasekaran@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=s-vadapalli@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox