From: Nishanth Menon <nm@ti.com>
To: Sinthu Raja <sinthu.raja@mistralsolutions.com>
Cc: Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Sinthu Raja <sinthu.raja@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Update IO EXP GPIO lines for Rev E2
Date: Wed, 15 Mar 2023 08:46:56 -0500 [thread overview]
Message-ID: <20230315134656.bt3mczw73h3z2j57@privacy> (raw)
In-Reply-To: <20230315120934.16954-1-sinthu.raja@ti.com>
On 17:39-20230315, Sinthu Raja wrote:
> From: Sinthu Raja <sinthu.raja@ti.com>
>
> Rev E2 of the AM68 SK baseboard has updated the GPIO IO expander pins
> functionality. To match the Rev E2 schematics, update existing IO expander
> GPIO line names and the corresponding node which uses the expansion(exp1)
> node.
>
> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> ---
>
> Schematics Ref: https://www.ti.com/lit/zip/sprr463
Looking at https://www.ti.com/tool/SK-AM68 looks like E1 never hit
production, is that correct?
Does this need a "Fixes" tag?
>
> arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> index 2091cd2431fb..27a43a8ecffd 100644
> --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> @@ -60,7 +60,7 @@ vdd_mmc1: regulator-sd {
> regulator-boot-on;
> enable-active-high;
> vin-supply = <&vsys_3v3>;
> - gpio = <&exp1 10 GPIO_ACTIVE_HIGH>;
> + gpio = <&exp1 8 GPIO_ACTIVE_HIGH>;
> };
>
> vdd_sd_dv: regulator-tlv71033 {
> @@ -264,12 +264,10 @@ exp1: gpio@21 {
> reg = <0x21>;
> gpio-controller;
> #gpio-cells = <2>;
> - gpio-line-names = "CSI_VIO_SEL", "CSI_SEL_FPC_EXPn", "HDMI_PDn",
> - "HDMI_LS_OE", "DP0_3V3 _EN", "BOARDID_EEPROM_WP",
> - "CAN_STB", " ", "GPIO_uSD_PWR_EN", "eDP_ENABLE",
> - "IO_EXP_PCIe1_M.2_RTSz", "IO_EXP_MCU_RGMII_RSTz",
> - "IO_EXP_CSI2_EXP_RSTz", " ", "CSI0_B_GPIO1",
> - "CSI1_B_GPIO1";
> + gpio-line-names = " ", " ", " ", " ", " ",
> + "BOARDID_EEPROM_WP", "CAN_STB", " ",
> + "GPIO_uSD_PWR_EN", " ", "IO_EXP_PCIe1_M.2_RTSz",
> + "IO_EXP_MCU_RGMII_RST#", " ", " ", " ", " ";
> };
> };
>
> --
> 2.36.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-15 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 12:09 [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Update IO EXP GPIO lines for Rev E2 Sinthu Raja
2023-03-15 13:46 ` Nishanth Menon [this message]
2023-03-15 13:54 ` Sinthu Raja M
2023-03-28 12:12 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315134656.bt3mczw73h3z2j57@privacy \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sinthu.raja@mistralsolutions.com \
--cc=sinthu.raja@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox