* [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Update IO EXP GPIO lines for Rev E2
@ 2023-03-15 12:09 Sinthu Raja
2023-03-15 13:46 ` Nishanth Menon
2023-03-28 12:12 ` Nishanth Menon
0 siblings, 2 replies; 4+ messages in thread
From: Sinthu Raja @ 2023-03-15 12:09 UTC (permalink / raw)
To: Nishanth Menon, Tero Kristo, Rob Herring
Cc: Vignesh Raghavendra, Krzysztof Kozlowski, linux-arm-kernel,
devicetree, linux-kernel, Sinthu Raja
From: Sinthu Raja <sinthu.raja@ti.com>
Rev E2 of the AM68 SK baseboard has updated the GPIO IO expander pins
functionality. To match the Rev E2 schematics, update existing IO expander
GPIO line names and the corresponding node which uses the expansion(exp1)
node.
Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
---
Schematics Ref: https://www.ti.com/lit/zip/sprr463
arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
index 2091cd2431fb..27a43a8ecffd 100644
--- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
@@ -60,7 +60,7 @@ vdd_mmc1: regulator-sd {
regulator-boot-on;
enable-active-high;
vin-supply = <&vsys_3v3>;
- gpio = <&exp1 10 GPIO_ACTIVE_HIGH>;
+ gpio = <&exp1 8 GPIO_ACTIVE_HIGH>;
};
vdd_sd_dv: regulator-tlv71033 {
@@ -264,12 +264,10 @@ exp1: gpio@21 {
reg = <0x21>;
gpio-controller;
#gpio-cells = <2>;
- gpio-line-names = "CSI_VIO_SEL", "CSI_SEL_FPC_EXPn", "HDMI_PDn",
- "HDMI_LS_OE", "DP0_3V3 _EN", "BOARDID_EEPROM_WP",
- "CAN_STB", " ", "GPIO_uSD_PWR_EN", "eDP_ENABLE",
- "IO_EXP_PCIe1_M.2_RTSz", "IO_EXP_MCU_RGMII_RSTz",
- "IO_EXP_CSI2_EXP_RSTz", " ", "CSI0_B_GPIO1",
- "CSI1_B_GPIO1";
+ gpio-line-names = " ", " ", " ", " ", " ",
+ "BOARDID_EEPROM_WP", "CAN_STB", " ",
+ "GPIO_uSD_PWR_EN", " ", "IO_EXP_PCIe1_M.2_RTSz",
+ "IO_EXP_MCU_RGMII_RST#", " ", " ", " ", " ";
};
};
--
2.36.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Update IO EXP GPIO lines for Rev E2
2023-03-15 12:09 [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Update IO EXP GPIO lines for Rev E2 Sinthu Raja
@ 2023-03-15 13:46 ` Nishanth Menon
2023-03-15 13:54 ` Sinthu Raja M
2023-03-28 12:12 ` Nishanth Menon
1 sibling, 1 reply; 4+ messages in thread
From: Nishanth Menon @ 2023-03-15 13:46 UTC (permalink / raw)
To: Sinthu Raja
Cc: Tero Kristo, Rob Herring, Vignesh Raghavendra,
Krzysztof Kozlowski, linux-arm-kernel, devicetree, linux-kernel,
Sinthu Raja
On 17:39-20230315, Sinthu Raja wrote:
> From: Sinthu Raja <sinthu.raja@ti.com>
>
> Rev E2 of the AM68 SK baseboard has updated the GPIO IO expander pins
> functionality. To match the Rev E2 schematics, update existing IO expander
> GPIO line names and the corresponding node which uses the expansion(exp1)
> node.
>
> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> ---
>
> Schematics Ref: https://www.ti.com/lit/zip/sprr463
Looking at https://www.ti.com/tool/SK-AM68 looks like E1 never hit
production, is that correct?
Does this need a "Fixes" tag?
>
> arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> index 2091cd2431fb..27a43a8ecffd 100644
> --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> @@ -60,7 +60,7 @@ vdd_mmc1: regulator-sd {
> regulator-boot-on;
> enable-active-high;
> vin-supply = <&vsys_3v3>;
> - gpio = <&exp1 10 GPIO_ACTIVE_HIGH>;
> + gpio = <&exp1 8 GPIO_ACTIVE_HIGH>;
> };
>
> vdd_sd_dv: regulator-tlv71033 {
> @@ -264,12 +264,10 @@ exp1: gpio@21 {
> reg = <0x21>;
> gpio-controller;
> #gpio-cells = <2>;
> - gpio-line-names = "CSI_VIO_SEL", "CSI_SEL_FPC_EXPn", "HDMI_PDn",
> - "HDMI_LS_OE", "DP0_3V3 _EN", "BOARDID_EEPROM_WP",
> - "CAN_STB", " ", "GPIO_uSD_PWR_EN", "eDP_ENABLE",
> - "IO_EXP_PCIe1_M.2_RTSz", "IO_EXP_MCU_RGMII_RSTz",
> - "IO_EXP_CSI2_EXP_RSTz", " ", "CSI0_B_GPIO1",
> - "CSI1_B_GPIO1";
> + gpio-line-names = " ", " ", " ", " ", " ",
> + "BOARDID_EEPROM_WP", "CAN_STB", " ",
> + "GPIO_uSD_PWR_EN", " ", "IO_EXP_PCIe1_M.2_RTSz",
> + "IO_EXP_MCU_RGMII_RST#", " ", " ", " ", " ";
> };
> };
>
> --
> 2.36.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Update IO EXP GPIO lines for Rev E2
2023-03-15 13:46 ` Nishanth Menon
@ 2023-03-15 13:54 ` Sinthu Raja M
0 siblings, 0 replies; 4+ messages in thread
From: Sinthu Raja M @ 2023-03-15 13:54 UTC (permalink / raw)
To: Nishanth Menon
Cc: Tero Kristo, Rob Herring, Vignesh Raghavendra,
Krzysztof Kozlowski, linux-arm-kernel, devicetree, linux-kernel,
Sinthu Raja
On Wed, Mar 15, 2023 at 7:17 PM Nishanth Menon <nm@ti.com> wrote:
>
> On 17:39-20230315, Sinthu Raja wrote:
> > From: Sinthu Raja <sinthu.raja@ti.com>
> >
> > Rev E2 of the AM68 SK baseboard has updated the GPIO IO expander pins
> > functionality. To match the Rev E2 schematics, update existing IO expander
> > GPIO line names and the corresponding node which uses the expansion(exp1)
> > node.
> >
> > Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> > ---
> >
> > Schematics Ref: https://www.ti.com/lit/zip/sprr463
>
> Looking at https://www.ti.com/tool/SK-AM68 looks like E1 never hit
> production, is that correct?
Yes, E1 didn't hit production.
>
> Does this need a "Fixes" tag?
It is a migration from E1 to E2 so I assume that a Fixes tag is not required.
Regards
Sinthu Raja
>
> >
> > arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 12 +++++-------
> > 1 file changed, 5 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> > index 2091cd2431fb..27a43a8ecffd 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> > @@ -60,7 +60,7 @@ vdd_mmc1: regulator-sd {
> > regulator-boot-on;
> > enable-active-high;
> > vin-supply = <&vsys_3v3>;
> > - gpio = <&exp1 10 GPIO_ACTIVE_HIGH>;
> > + gpio = <&exp1 8 GPIO_ACTIVE_HIGH>;
> > };
> >
> > vdd_sd_dv: regulator-tlv71033 {
> > @@ -264,12 +264,10 @@ exp1: gpio@21 {
> > reg = <0x21>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > - gpio-line-names = "CSI_VIO_SEL", "CSI_SEL_FPC_EXPn", "HDMI_PDn",
> > - "HDMI_LS_OE", "DP0_3V3 _EN", "BOARDID_EEPROM_WP",
> > - "CAN_STB", " ", "GPIO_uSD_PWR_EN", "eDP_ENABLE",
> > - "IO_EXP_PCIe1_M.2_RTSz", "IO_EXP_MCU_RGMII_RSTz",
> > - "IO_EXP_CSI2_EXP_RSTz", " ", "CSI0_B_GPIO1",
> > - "CSI1_B_GPIO1";
> > + gpio-line-names = " ", " ", " ", " ", " ",
> > + "BOARDID_EEPROM_WP", "CAN_STB", " ",
> > + "GPIO_uSD_PWR_EN", " ", "IO_EXP_PCIe1_M.2_RTSz",
> > + "IO_EXP_MCU_RGMII_RST#", " ", " ", " ", " ";
> > };
> > };
> >
> > --
> > 2.36.1
> >
>
> --
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
--
With Regards
Sinthu Raja
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Update IO EXP GPIO lines for Rev E2
2023-03-15 12:09 [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Update IO EXP GPIO lines for Rev E2 Sinthu Raja
2023-03-15 13:46 ` Nishanth Menon
@ 2023-03-28 12:12 ` Nishanth Menon
1 sibling, 0 replies; 4+ messages in thread
From: Nishanth Menon @ 2023-03-28 12:12 UTC (permalink / raw)
To: Tero Kristo, Rob Herring, Sinthu Raja
Cc: Nishanth Menon, Vignesh Raghavendra, Krzysztof Kozlowski,
linux-arm-kernel, devicetree, linux-kernel, Sinthu Raja
Hi Sinthu Raja,
On Wed, 15 Mar 2023 17:39:34 +0530, Sinthu Raja wrote:
> Rev E2 of the AM68 SK baseboard has updated the GPIO IO expander pins
> functionality. To match the Rev E2 schematics, update existing IO expander
> GPIO line names and the corresponding node which uses the expansion(exp1)
> node.
>
>
I have applied the following to branch ti-k3-dts-next on [1].
Thank you!
[1/1] arm64: dts: ti: k3-am68-sk-base-board: Update IO EXP GPIO lines for Rev E2
commit: 276fa0066b03875f77dba67867d9902361e646fc
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-28 12:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-15 12:09 [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Update IO EXP GPIO lines for Rev E2 Sinthu Raja
2023-03-15 13:46 ` Nishanth Menon
2023-03-15 13:54 ` Sinthu Raja M
2023-03-28 12:12 ` Nishanth Menon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox