* [PATCH] drm/imx/lcdc: Fix compilation with CONFIG_OF=n
@ 2023-03-18 22:10 Uwe Kleine-König
2023-03-20 9:22 ` Uwe Kleine-König
0 siblings, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2023-03-18 22:10 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Philipp Zabel
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
dri-devel, linux-arm-kernel, kernel test robot
The driver needs the include <drm/drm_bridge.h>. WIth CONFIG_OF enabled
this is provided by a conditional include in <drm/drm_of.h>.
To fix building the lcdc driver with CONFIG_OF=n, include
<drm/drm_bridge.h> explicitly.
Fixes: c87e859cdeb5 ("drm/imx/lcdc: Implement DRM driver for imx25")
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202303190127.uylmokJl-lkp@intel.com/
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/gpu/drm/imx/lcdc/imx-lcdc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/imx/lcdc/imx-lcdc.c b/drivers/gpu/drm/imx/lcdc/imx-lcdc.c
index 24bc7b310367..8e6d457917da 100644
--- a/drivers/gpu/drm/imx/lcdc/imx-lcdc.c
+++ b/drivers/gpu/drm/imx/lcdc/imx-lcdc.c
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: GPL-2.0-only
// SPDX-FileCopyrightText: 2020 Marian Cichy <M.Cichy@pengutronix.de>
+#include <drm/drm_bridge.h>
#include <drm/drm_bridge_connector.h>
#include <drm/drm_damage_helper.h>
#include <drm/drm_drv.h>
base-commit: c87e859cdeb5d106cb861326e3135c606d61f88d
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/imx/lcdc: Fix compilation with CONFIG_OF=n
2023-03-18 22:10 [PATCH] drm/imx/lcdc: Fix compilation with CONFIG_OF=n Uwe Kleine-König
@ 2023-03-20 9:22 ` Uwe Kleine-König
2023-04-15 21:27 ` Javier Martinez Canillas
0 siblings, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2023-03-20 9:22 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Philipp Zabel
Cc: kernel test robot, Shawn Guo, dri-devel, NXP Linux Team,
Pengutronix Kernel Team, Fabio Estevam, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 492 bytes --]
Hello,
On Sat, Mar 18, 2023 at 11:10:27PM +0100, Uwe Kleine-König wrote:
> The driver needs the include <drm/drm_bridge.h>. WIth CONFIG_OF enabled
Just noticed: s/WIth/With/. Assuming no further review comments make a
v2 necessary: Should I resend for that, or can you fixup when you apply
this patch?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/imx/lcdc: Fix compilation with CONFIG_OF=n
2023-03-20 9:22 ` Uwe Kleine-König
@ 2023-04-15 21:27 ` Javier Martinez Canillas
2023-04-15 21:47 ` Javier Martinez Canillas
0 siblings, 1 reply; 6+ messages in thread
From: Javier Martinez Canillas @ 2023-04-15 21:27 UTC (permalink / raw)
To: Uwe Kleine-König, David Airlie, Daniel Vetter, Philipp Zabel
Cc: kernel test robot, Shawn Guo, dri-devel, NXP Linux Team,
Pengutronix Kernel Team, linux-arm-kernel
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
Hello Uwe,
> Hello,
>
> On Sat, Mar 18, 2023 at 11:10:27PM +0100, Uwe Kleine-König wrote:
>> The driver needs the include <drm/drm_bridge.h>. WIth CONFIG_OF enabled
>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> Just noticed: s/WIth/With/. Assuming no further review comments make a
> v2 necessary: Should I resend for that, or can you fixup when you apply
> this patch?
>
No need to resend, I'll fix it when pushing to drm-misc-next.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/imx/lcdc: Fix compilation with CONFIG_OF=n
2023-04-15 21:27 ` Javier Martinez Canillas
@ 2023-04-15 21:47 ` Javier Martinez Canillas
2023-04-16 16:55 ` Uwe Kleine-König
0 siblings, 1 reply; 6+ messages in thread
From: Javier Martinez Canillas @ 2023-04-15 21:47 UTC (permalink / raw)
To: Uwe Kleine-König, David Airlie, Daniel Vetter, Philipp Zabel
Cc: kernel test robot, Shawn Guo, dri-devel, NXP Linux Team,
Pengutronix Kernel Team, linux-arm-kernel
Javier Martinez Canillas <javierm@redhat.com> writes:
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
>
> Hello Uwe,
>
>> Hello,
>>
>> On Sat, Mar 18, 2023 at 11:10:27PM +0100, Uwe Kleine-König wrote:
>>> The driver needs the include <drm/drm_bridge.h>. WIth CONFIG_OF enabled
>>
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
>
>
>> Just noticed: s/WIth/With/. Assuming no further review comments make a
>> v2 necessary: Should I resend for that, or can you fixup when you apply
>> this patch?
>>
>
> No need to resend, I'll fix it when pushing to drm-misc-next.
>
This issue was already fixed by Dave in commit b24343eaceed ("Merge tag
'drm-misc-next-2023-03-16' of git://anongit.freedesktop.org/drm/drm-misc
into drm-next").
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/imx/lcdc: Fix compilation with CONFIG_OF=n
2023-04-15 21:47 ` Javier Martinez Canillas
@ 2023-04-16 16:55 ` Uwe Kleine-König
2023-04-16 17:06 ` Javier Martinez Canillas
0 siblings, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2023-04-16 16:55 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: David Airlie, Daniel Vetter, Philipp Zabel, kernel test robot,
dri-devel, NXP Linux Team, Pengutronix Kernel Team, Shawn Guo,
linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1217 bytes --]
Hello Javier,
On Sat, Apr 15, 2023 at 11:47:22PM +0200, Javier Martinez Canillas wrote:
> Javier Martinez Canillas <javierm@redhat.com> writes:
>
> > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
> >
> > Hello Uwe,
> >
> >> Hello,
> >>
> >> On Sat, Mar 18, 2023 at 11:10:27PM +0100, Uwe Kleine-König wrote:
> >>> The driver needs the include <drm/drm_bridge.h>. WIth CONFIG_OF enabled
> >>
> >
> > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> >
> >
> >> Just noticed: s/WIth/With/. Assuming no further review comments make a
> >> v2 necessary: Should I resend for that, or can you fixup when you apply
> >> this patch?
> >>
> >
> > No need to resend, I'll fix it when pushing to drm-misc-next.
> >
>
> This issue was already fixed by Dave in commit b24343eaceed ("Merge tag
> 'drm-misc-next-2023-03-16' of git://anongit.freedesktop.org/drm/drm-misc
> into drm-next").
FTR: s/b24343eaceed/c6265f5c2f50/
Thanks for looking into this, and also the other patch for imx-lcdc!
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/imx/lcdc: Fix compilation with CONFIG_OF=n
2023-04-16 16:55 ` Uwe Kleine-König
@ 2023-04-16 17:06 ` Javier Martinez Canillas
0 siblings, 0 replies; 6+ messages in thread
From: Javier Martinez Canillas @ 2023-04-16 17:06 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: David Airlie, Daniel Vetter, Philipp Zabel, kernel test robot,
dri-devel, NXP Linux Team, Pengutronix Kernel Team, Shawn Guo,
linux-arm-kernel
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
[...]
>>
>> This issue was already fixed by Dave in commit b24343eaceed ("Merge tag
>> 'drm-misc-next-2023-03-16' of git://anongit.freedesktop.org/drm/drm-misc
>> into drm-next").
>
> FTR: s/b24343eaceed/c6265f5c2f50/
>
Ups indeed. I pasted the wrong commit :)
> Thanks for looking into this, and also the other patch for imx-lcdc!
>
You are welcome!
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-04-16 17:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-18 22:10 [PATCH] drm/imx/lcdc: Fix compilation with CONFIG_OF=n Uwe Kleine-König
2023-03-20 9:22 ` Uwe Kleine-König
2023-04-15 21:27 ` Javier Martinez Canillas
2023-04-15 21:47 ` Javier Martinez Canillas
2023-04-16 16:55 ` Uwe Kleine-König
2023-04-16 17:06 ` Javier Martinez Canillas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox