From: Andi Shyti <andi.shyti@kernel.org>
To: Ryan Chen <ryan_chen@aspeedtech.com>
Cc: jk@codeconstruct.com.au, openbmc@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Linus Walleij <linus.walleij@linaro.org>,
linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH v7 2/2] i2c: aspeed: support ast2600 i2c new register mode driver
Date: Tue, 28 Mar 2023 15:12:19 +0200 [thread overview]
Message-ID: <20230328131219.khfd2jz3z4es5bzy@intel.intel> (raw)
In-Reply-To: <20230327092524.3916389-3-ryan_chen@aspeedtech.com>
Hi Ryan,
[...]
> + ret = of_property_read_u32(dev->of_node,
> + "i2c-scl-clk-low-timeout-us",
> + &i2c_bus->timeout);
in your v6 patch this was a boolean value. If you need to keep it
boolean you have the "i2c-scl-has-clk-low-timeout".
> + if (ret < 0) {
> + i2c_bus->timeout = 0;
> + } else {
> + /* i2c timeout counter: use base clk4 1Mhz
> + * per unit: 1/(1000/4096) = 4096us
> + */
> + i2c_bus->timeout /= 4096;
> + }
Can you please run checkpatch.pl before sending the patch?
[...]
> + dev_info(dev, "%s [%d]: adapter [%d khz] mode [%d]\n",
> + dev->of_node->name, i2c_bus->adap.nr, i2c_bus->bus_frequency / 1000,
> + i2c_bus->mode);
> +
> + return 0;
> +
> + return ret;
can you also please do some cleanups before sending the patch?
Thanks,
Andi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-28 13:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 9:25 [PATCH v7 0/2] Add ASPEED AST2600 I2Cv2 controller driver Ryan Chen
2023-03-27 9:25 ` [PATCH v7 1/2] dt-bindings: i2c: aspeed: support for AST2600-i2cv2 Ryan Chen
2023-03-28 11:49 ` Krzysztof Kozlowski
2023-03-27 9:25 ` [PATCH v7 2/2] i2c: aspeed: support ast2600 i2c new register mode driver Ryan Chen
2023-03-28 13:12 ` Andi Shyti [this message]
2023-03-29 1:06 ` Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328131219.khfd2jz3z4es5bzy@intel.intel \
--to=andi.shyti@kernel.org \
--cc=andrew@aj.id.au \
--cc=jk@codeconstruct.com.au \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox