From: Nishanth Menon <nm@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Santosh Shilimkar" <ssantosh@kernel.org>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
"Tony Lindgren" <tony@atomide.com>
Subject: Re: [PATCH] soc: ti: smartreflex: Simplify getting the opam_sr pointer
Date: Fri, 14 Apr 2023 13:33:50 -0500 [thread overview]
Message-ID: <20230414183350.mdvl2gcf6vaere2w@coleslaw> (raw)
In-Reply-To: <cb3e16f0-cdef-42da-8761-8e729578e108@app.fastmail.com>
On 18:04-20230414, Arnd Bergmann wrote:
> On Wed, Apr 12, 2023, at 16:25, Uwe Kleine-König wrote:
> > Hello,
> >
> > [Cc += Tony Lindgren + Arnd Bergmann who did care about the last change
> > to this driver]
> >
> > On Wed, Oct 12, 2022 at 04:00:32PM +0200, Uwe Kleine-König wrote:
> >> The probe function stores the sr_info pointer using
> >> platform_set_drvdata(). Use the corresponding platform_get_drvdata() to
> >> retrieve that pointer in the remove and shutdown functions.
> >>
> >> This simplifies these functions and makes error handling unnecessary.
> >> This is a good thing as at least for .remove() returning an error code
> >> doesn't have the desired effect.
> >>
> >> This is a preparation for making platform remove callbacks return void.
> >>
> >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >
> > This patch still applies to v6.3-rc1, but I didn't get any feedback
> > since 6 months now. I need this change to eventually make
> > platform_driver's remove callback return void.
>
> Applied to the soc/drivers branch for 6.4 now.
>
> Arnd
Thanks Arnd, Tony.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-04-14 18:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 14:00 [PATCH] soc: ti: smartreflex: Simplify getting the opam_sr pointer Uwe Kleine-König
2022-12-19 21:41 ` Uwe Kleine-König
2023-04-12 14:25 ` Uwe Kleine-König
2023-04-13 5:29 ` Tony Lindgren
2023-04-14 16:04 ` Arnd Bergmann
2023-04-14 18:33 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230414183350.mdvl2gcf6vaere2w@coleslaw \
--to=nm@ti.com \
--cc=arnd@arndb.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox