From: Nishanth Menon <nm@ti.com>
To: Udit Kumar <u-kumar1@ti.com>
Cc: <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<m-chawdhry@ti.com>, <n-francis@ti.com>
Subject: Re: [PATCH 3/5] arm64: dts: ti: k3-j7200: main_pmx0 clean up
Date: Wed, 26 Apr 2023 07:51:45 -0500 [thread overview]
Message-ID: <20230426125145.wb6qbhb3c7igx45j@seldom> (raw)
In-Reply-To: <20230426103219.1565266-4-u-kumar1@ti.com>
On 16:02-20230426, Udit Kumar wrote:
> This patch removes duplicated define of main_i2c0
> and adds main_uart0 pin mux.
>
> Signed-off-by: Udit Kumar <u-kumar1@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> index 63633e4f6c59..37eb24d69924 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> @@ -107,10 +107,12 @@ J721E_WKUP_IOPAD(0x0030, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */
> };
>
> &main_pmx0 {
> - main_i2c0_pins_default: main-i2c0-pins-default {
nice catch, but We should clean up the reference in
common-proc-board.dts, which would make it it's own patch. Also
indicate that the definition is already present in som.dtsi
> + main_uart0_pins_default: main_uart0_pins_default {
> pinctrl-single,pins = <
> - J721E_IOPAD(0xd4, PIN_INPUT_PULLUP, 0) /* (V3) I2C0_SCL */
> - J721E_IOPAD(0xd8, PIN_INPUT_PULLUP, 0) /* (W2) I2C0_SDA */
> + J721E_IOPAD(0xb0, PIN_INPUT, 0) /* (T16) UART0_RXD */
> + J721E_IOPAD(0xb4, PIN_OUTPUT, 0) /* (T17) UART0_TXD */
> + J721E_IOPAD(0xc0, PIN_INPUT, 2) /* (W3) SPI0_CS0.UART0_CTSn */
> + J721E_IOPAD(0xc4, PIN_OUTPUT, 2) /* (U5) SPI0_CS1.UART0_RTSn */
> >;
> };
>
> @@ -163,6 +165,8 @@ &main_uart0 {
> status = "okay";
> /* Shared with ATF on this platform */
> power-domains = <&k3_pds 146 TI_SCI_PD_SHARED>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&main_uart0_pins_default>;
> };
>
> &main_uart1 {
> --
> 2.34.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-26 12:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 10:32 [PATCH 0/5] arm64: dts: ti: k3-j7200: Add properties and sync with uboot Udit Kumar
2023-04-26 10:32 ` [PATCH 1/5] arm64: dts: ti: k3-j7200: Add general purpose timers Udit Kumar
2023-04-27 8:00 ` Tony Lindgren
2023-04-27 10:09 ` [EXTERNAL] " Kumar, Udit
2023-04-28 5:49 ` Tony Lindgren
2023-05-31 21:51 ` Nishanth Menon
2023-04-26 10:32 ` [PATCH 2/5] arm64: dts: ti: k3-j7200: Configure pinctrl for timer IO Udit Kumar
2023-04-26 10:32 ` [PATCH 3/5] arm64: dts: ti: k3-j7200: main_pmx0 clean up Udit Kumar
2023-04-26 12:51 ` Nishanth Menon [this message]
2023-04-26 14:17 ` Kumar, Udit
2023-04-26 10:32 ` [PATCH 4/5] arm64: dts: ti: k3-j7200: Add uart pin mux in wkup_pmx0 Udit Kumar
2023-04-26 10:32 ` [PATCH 5/5] arm64: dts: ti: k3-j7200: Add bootph-pre-ram for u-boot Udit Kumar
2023-04-26 12:48 ` Nishanth Menon
2023-04-26 14:19 ` Kumar, Udit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230426125145.wb6qbhb3c7igx45j@seldom \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-chawdhry@ti.com \
--cc=n-francis@ti.com \
--cc=robh+dt@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox