From: Will Deacon <will@kernel.org>
To: ye.xingchen@zte.com.cn
Cc: broonie@kernel.org, catalin.marinas@arm.com,
kristina.martsenko@arm.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: mm: use bitmap_zero() API
Date: Tue, 16 May 2023 14:24:28 +0100 [thread overview]
Message-ID: <20230516132427.GA30894@willie-the-truck> (raw)
In-Reply-To: <202305061636313011243@zte.com.cn>
On Sat, May 06, 2023 at 04:36:31PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> bitmap_zero() is faster than bitmap_clear(), so use bitmap_zero()
> instead of bitmap_clear().
Is it? Don't these both boil down to:
memset(asid_map, 0, NUM_USER_ASIDS / 8)
?
Will
> ---
> arch/arm64/mm/context.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/mm/context.c b/arch/arm64/mm/context.c
> index e1e0dca01839..ed0bf7f8e8ce 100644
> --- a/arch/arm64/mm/context.c
> +++ b/arch/arm64/mm/context.c
> @@ -95,7 +95,7 @@ static void set_reserved_asid_bits(void)
> else if (arm64_kernel_unmapped_at_el0())
> set_kpti_asid_bits(asid_map);
> else
> - bitmap_clear(asid_map, 0, NUM_USER_ASIDS);
> + bitmap_zero(asid_map, NUM_USER_ASIDS);
> }
>
> #define asid_gen_match(asid) \
> --
> 2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-05-16 13:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-06 8:36 [PATCH] arm64: mm: use bitmap_zero() API ye.xingchen
2023-05-16 13:24 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230516132427.GA30894@willie-the-truck \
--to=will@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kristina.martsenko@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox