From: Andi Shyti <andi.shyti@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Russell King <linux@armlinux.org.uk>,
patches@opensource.cirrus.com,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] ARM: s3c: Switch i2c drivers back to use .probe()
Date: Sat, 27 May 2023 00:51:20 +0200 [thread overview]
Message-ID: <20230526225120.rhgjukx5uyqmmj66@intel.intel> (raw)
In-Reply-To: <20230526214003.2134595-1-u.kleine-koenig@pengutronix.de>
Hi Uwe,
On Fri, May 26, 2023 at 11:40:03PM +0200, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Thanks,
Andi
> ---
> arch/arm/mach-s3c/mach-crag6410-module.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-s3c/mach-crag6410-module.c b/arch/arm/mach-s3c/mach-crag6410-module.c
> index 4edde13b89b5..8fce1e815ee8 100644
> --- a/arch/arm/mach-s3c/mach-crag6410-module.c
> +++ b/arch/arm/mach-s3c/mach-crag6410-module.c
> @@ -418,7 +418,7 @@ static struct i2c_driver wlf_gf_module_driver = {
> .driver = {
> .name = "wlf-gf-module"
> },
> - .probe_new = wlf_gf_module_probe,
> + .probe = wlf_gf_module_probe,
> .id_table = wlf_gf_module_id,
> };
>
>
> base-commit: ac9a78681b921877518763ba0e89202254349d1b
> --
> 2.39.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-26 22:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 21:40 [PATCH] ARM: s3c: Switch i2c drivers back to use .probe() Uwe Kleine-König
2023-05-26 22:51 ` Andi Shyti [this message]
2023-05-30 7:45 ` Krzysztof Kozlowski
2023-05-30 12:14 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230526225120.rhgjukx5uyqmmj66@intel.intel \
--to=andi.shyti@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=patches@opensource.cirrus.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox