[PATCH] ARM: s3c: Switch i2c drivers back to use .probe()

[PATCH] ARM: s3c: Switch i2c drivers back to use .probe()

[Uwe Kleine-König]

After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
call-back type"), all drivers being converted to .probe_new() and then
03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
convert back to (the new) .probe() to be able to eventually drop
.probe_new() from struct i2c_driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 arch/arm/mach-s3c/mach-crag6410-module.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-s3c/mach-crag6410-module.c b/arch/arm/mach-s3c/mach-crag6410-module.c
index 4edde13b89b5..8fce1e815ee8 100644
--- a/arch/arm/mach-s3c/mach-crag6410-module.c
+++ b/arch/arm/mach-s3c/mach-crag6410-module.c
@@ -418,7 +418,7 @@ static struct i2c_driver wlf_gf_module_driver = {
 	.driver = {
 		.name = "wlf-gf-module"
 	},
-	.probe_new = wlf_gf_module_probe,
+	.probe = wlf_gf_module_probe,
 	.id_table = wlf_gf_module_id,
 };
 

base-commit: ac9a78681b921877518763ba0e89202254349d1b
-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: s3c: Switch i2c drivers back to use .probe()

[Andi Shyti]

Hi Uwe,

On Fri, May 26, 2023 at 11:40:03PM +0200, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Andi Shyti <andi.shyti@kernel.org> 

Thanks,
Andi

> ---
>  arch/arm/mach-s3c/mach-crag6410-module.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-s3c/mach-crag6410-module.c b/arch/arm/mach-s3c/mach-crag6410-module.c
> index 4edde13b89b5..8fce1e815ee8 100644
> --- a/arch/arm/mach-s3c/mach-crag6410-module.c
> +++ b/arch/arm/mach-s3c/mach-crag6410-module.c
> @@ -418,7 +418,7 @@ static struct i2c_driver wlf_gf_module_driver = {
>  	.driver = {
>  		.name = "wlf-gf-module"
>  	},
> -	.probe_new = wlf_gf_module_probe,
> +	.probe = wlf_gf_module_probe,
>  	.id_table = wlf_gf_module_id,
>  };
>  
> 
> base-commit: ac9a78681b921877518763ba0e89202254349d1b
> -- 
> 2.39.2
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: s3c: Switch i2c drivers back to use .probe()

[Krzysztof Kozlowski]

On Fri, 26 May 2023 23:40:03 +0200, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
> 
> 
> [...]


Fixed checkpatch issue in commit and applied. Please don't skip checkpatch on
your submissions.

Applied, thanks!

[1/1] ARM: s3c: Switch i2c drivers back to use .probe()
      https://git.kernel.org/krzk/linux/c/ca027ae58eaab3632966158ce440a7f50da52bef

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: s3c: Switch i2c drivers back to use .probe()

[Uwe Kleine-König]

[-- Attachment #1.1: Type: text/plain, Size: 1088 bytes --]

On Tue, May 30, 2023 at 09:45:48AM +0200, Krzysztof Kozlowski wrote:
> 
> On Fri, 26 May 2023 23:40:03 +0200, Uwe Kleine-König wrote:
> > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> > call-back type"), all drivers being converted to .probe_new() and then
> > 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> > convert back to (the new) .probe() to be able to eventually drop
> > .probe_new() from struct i2c_driver.
> > 
> > 
> > [...]
> 
> 
> Fixed checkpatch issue in commit and applied. Please don't skip checkpatch on
> your submissions.
> 
> Applied, thanks!
> 
> [1/1] ARM: s3c: Switch i2c drivers back to use .probe()
>       https://git.kernel.org/krzk/linux/c/ca027ae58eaab3632966158ce440a7f50da52bef

I'm aware checkpatch wanted another "commit" but I didn't add it
consciously because it sounds strange in my (German) ear. *shrug*

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel