From: Conor Dooley <conor@kernel.org>
To: Kamlesh Gurudasani <kamlesh@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jayesh Choudhary <j-choudhary@ti.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: crypto: ti,sa2ul: make power-domains conditional
Date: Mon, 19 Jun 2023 21:27:33 +0100 [thread overview]
Message-ID: <20230619-trailside-shaft-72b2d6bcf978@spud> (raw)
In-Reply-To: <20230614-sa3ul-v3-1-2eeb810327a1@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 1568 bytes --]
On Mon, Jun 19, 2023 at 06:58:47PM +0530, Kamlesh Gurudasani wrote:
> Devices specific to compatible ti,am62-sa3ul don't have control over
> power of SA3UL from main domain.
>
> "power-domains" property in crypto node tries to access
> the SA3UL power, for which it gets NACK and hence, driver doesn't
> probe properly for those particular devices.
>
> Make "power-domains" property as false for devices with
> compatible ti,am62-sa3ul.
>
> Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com>
> ---
> Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> index 77ec8bc70bf7..88c8ee8821d4 100644
> --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> @@ -66,10 +66,22 @@ patternProperties:
> required:
> - compatible
> - reg
> - - power-domains
> - dmas
> - dma-names
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + items:
The usual pattern here is s/items/contains/. With that,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
> + const: ti,am62-sa3ul
> + then:
> + properties:
> + power-domains: false
> + else:
> + required:
> + - power-domains
> +
> additionalProperties: false
>
> examples:
>
> --
> 2.34.1
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-19 20:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 13:28 [PATCH v3 0/2] Remove power-domains property for devices with compatible ti,am62-sa3ul Kamlesh Gurudasani
2023-06-19 13:28 ` [PATCH v3 1/2] dt-bindings: crypto: ti,sa2ul: make power-domains conditional Kamlesh Gurudasani
2023-06-19 20:27 ` Conor Dooley [this message]
2023-06-19 13:28 ` [PATCH v3 2/2] arm64: dts: ti: k3-am62-main: Remove power-domains from crypto node Kamlesh Gurudasani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230619-trailside-shaft-72b2d6bcf978@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j-choudhary@ti.com \
--cc=kamlesh@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox