From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Yangtao Li <frank.li@vivo.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/58] mmc: dw_mmc: exynos: Convert to platform remove callback returning void
Date: Thu, 13 Jul 2023 11:02:30 +0200 [thread overview]
Message-ID: <20230713090230.iwhicjbirll5icec@pengutronix.de> (raw)
In-Reply-To: <75d2dc5e-4cbf-2519-cdf7-8fde374126ec@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 1136 bytes --]
On Thu, Jul 13, 2023 at 10:11:15AM +0200, Krzysztof Kozlowski wrote:
> On 13/07/2023 10:07, Yangtao Li wrote:
> > The .remove() callback for a platform driver returns an int which makes
> > many driver authors wrongly assume it's possible to do error handling by
> > returning an error code. However the value returned is (mostly) ignored
> > and this typically results in resource leaks. To improve here there is a
> > quest to make the remove callback return void. In the first step of this
> > quest all drivers are converted to .remove_new() which already returns
> > void.
> >
> > Trivially convert this driver from always returning zero in the remove
> > callback to the void returning variant.
>
> You even copied Uwe's commit msg... Aren't you duplicate his work or is
> it being coordinated?
We communicated and I politely asked to not interfer. This series is
just what Yangtao had still pending. That's fine for me.
Thanks for noticing,
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-13 9:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 8:07 [PATCH 01/58] mmc: sunxi: Convert to platform remove callback returning void Yangtao Li
2023-07-13 8:07 ` [PATCH 02/58] mmc: bcm2835: " Yangtao Li
2023-07-14 10:10 ` Florian Fainelli
2023-07-13 8:07 ` [PATCH 05/58] mmc: mtk-sd: " Yangtao Li
2023-07-13 8:07 ` [PATCH 10/58] mmc: sdhci: milbeaut: " Yangtao Li
2023-07-13 8:07 ` [PATCH 12/58] mmc: sdhci-of-at91: " Yangtao Li
2023-07-13 8:07 ` [PATCH 14/58] mmc: dw_mmc: exynos: " Yangtao Li
2023-07-13 8:11 ` Krzysztof Kozlowski
2023-07-13 9:02 ` Uwe Kleine-König [this message]
2023-07-13 8:07 ` [PATCH 18/58] mmc: meson-gx: " Yangtao Li
2023-07-13 8:07 ` [PATCH 21/58] mmc: meson-mx-sdhc: " Yangtao Li
2023-07-13 8:07 ` [PATCH 23/58] mmc: mxs-mmc: " Yangtao Li
2023-07-13 8:07 ` [PATCH 25/58] mmc: uniphier-sd: " Yangtao Li
2023-07-13 9:09 ` Uwe Kleine-König
2023-07-13 8:07 ` [PATCH 27/58] mmc: sdhci-of-arasan: " Yangtao Li
2023-07-13 8:07 ` [PATCH 34/58] mmc: sdhci-of-aspeed: " Yangtao Li
2023-07-13 9:13 ` Uwe Kleine-König
2023-07-13 8:07 ` [PATCH 35/58] mmc: meson-mx-sdio: " Yangtao Li
2023-07-13 8:07 ` [PATCH 39/58] mmc: sdhci-esdhc-imx: " Yangtao Li
2023-07-13 8:07 ` [PATCH 42/58] mmc: dw_mmc: rockchip: " Yangtao Li
2023-07-13 8:07 ` [PATCH 43/58] mmc: owl: " Yangtao Li
2023-07-13 8:07 ` [PATCH 46/58] mmc: atmel-mci: " Yangtao Li
2023-07-13 8:07 ` [PATCH 47/58] mmc: sdhci-st: " Yangtao Li
2023-07-13 8:07 ` [PATCH 48/58] mmc: wmt-sdmmc: " Yangtao Li
2023-07-13 8:08 ` [PATCH 58/58] mmc: " Yangtao Li
2023-07-14 7:49 ` Adrian Hunter
2023-07-14 10:12 ` Florian Fainelli
2023-07-13 15:13 ` [PATCH 01/58] mmc: sunxi: " Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230713090230.iwhicjbirll5icec@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=alim.akhtar@samsung.com \
--cc=frank.li@vivo.com \
--cc=jh80.chung@samsung.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox