From: Nishanth Menon <nm@ti.com>
To: Jayesh Choudhary <j-choudhary@ti.com>
Cc: <vigneshr@ti.com>, <krzysztof.kozlowski+dt@linaro.org>,
<afd@ti.com>, <s-vadapalli@ti.com>, <kristo@kernel.org>,
<robh+dt@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 3/5] arm64: dts: ti: k3-j784s4: Add WIZ and SERDES PHY nodes
Date: Thu, 13 Jul 2023 13:21:07 -0500 [thread overview]
Message-ID: <20230713182107.ashuygyg4x4j77s5@backboard> (raw)
In-Reply-To: <18310450-05f3-172c-e4bc-fda114f333a4@ti.com>
On 21:01-20230713, Jayesh Choudhary wrote:
>
>
> On 12/07/23 19:48, Nishanth Menon wrote:
> > On 15:47-20230710, Jayesh Choudhary wrote:
> > > From: Siddharth Vadapalli <s-vadapalli@ti.com>
> > >
> > > J784S4 SoC has 4 Serdes instances along with their respective WIZ
> > > instances. Add device-tree nodes for them and disable them by default.
> > >
> > > Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> > > [j-choudhary@ti.com: fix serdes_wiz clock order]
> > > Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> > > ---
> > NAK. This patch introduces the following dtbs_check warning.
> > arch/arm64/boot/dts/ti/k3-am69-sk.dtb: serdes-refclk: 'clock-frequency' is a required property
> >
>
> Sorry for this. This property was added in the final board file.
> I will fix it in the next revision.
> I will add '0' as clock-property in the main file similar to j721e[1]
> which will be overridden in the board file with required value to get
> rid of this warning.
That would follow what renesas (r8a774a1.dtsi) and imx
(imx8dxl-ss-conn.dtsi) seem to be doing as well. Just make sure to add
documentation to the property to indicate expectation. Unless someone
has objections to this approach.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-13 18:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 10:17 [PATCH v5 0/5] Add peripherals for J784S4 Jayesh Choudhary
2023-07-10 10:17 ` [PATCH v5 1/5] arm64: dts: ti: k3-j784s4-main: Add system controller and SERDES lane mux Jayesh Choudhary
2023-07-10 11:43 ` Krzysztof Kozlowski
2023-07-11 6:31 ` Jayesh Choudhary
2023-07-11 15:31 ` Nishanth Menon
2023-07-12 5:44 ` Krzysztof Kozlowski
2023-07-12 11:21 ` Roger Quadros
2023-07-12 12:43 ` Jayesh Choudhary
2023-07-10 10:17 ` [PATCH v5 2/5] arm64: dts: ti: k3-j784s4: Add Main CPSW2G node Jayesh Choudhary
2023-07-10 10:17 ` [PATCH v5 3/5] arm64: dts: ti: k3-j784s4: Add WIZ and SERDES PHY nodes Jayesh Choudhary
2023-07-12 14:18 ` Nishanth Menon
2023-07-13 15:31 ` Jayesh Choudhary
2023-07-13 18:21 ` Nishanth Menon [this message]
2023-07-13 18:31 ` Andrew Davis
2023-07-13 18:58 ` Nishanth Menon
2023-07-20 9:36 ` Jayesh Choudhary
2023-07-21 13:26 ` Jayesh Choudhary
2023-07-10 10:17 ` [PATCH v5 4/5] arm64: dts: ti: k3-j784s4-main: Add DSS and DP-bridge node Jayesh Choudhary
2023-07-10 10:17 ` [PATCH v5 5/5] arm64: dts: ti: k3-j784s4-evm: Enable DisplayPort-0 Jayesh Choudhary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230713182107.ashuygyg4x4j77s5@backboard \
--to=nm@ti.com \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=j-choudhary@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox