* [PATCH 1/3] dt-bindings: media: amphion: Fix subnode pattern
@ 2023-07-21 11:10 Alexander Stein
2023-07-21 11:10 ` [PATCH 2/3] dt-bindings: lpspi: Add power-domains Alexander Stein
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Alexander Stein @ 2023-07-21 11:10 UTC (permalink / raw)
To: Rob Herring, Ming Qian, Shijie Qin, Zhou Peng,
Mauro Carvalho Chehab, Krzysztof Kozlowski, Conor Dooley,
Mirela Rabulea, Shawn Guo, Sascha Hauer, Fabio Estevam,
Mark Brown, Anson Huang
Cc: Alexander Stein, NXP Linux Team, Pengutronix Kernel Team,
linux-media, devicetree, linux-arm-kernel, linux-spi
DT nodes use dashes instead of underscore. Adjust pattern to also fix
warnings regarding nodes in arch/arm64/boot/dts/freescale/imx8-ss-vpu.dtsi
Fixes: 38ad8b32f3af ("dt-bindings: media: amphion: add amphion video codec bindings")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Documentation/devicetree/bindings/media/amphion,vpu.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/media/amphion,vpu.yaml b/Documentation/devicetree/bindings/media/amphion,vpu.yaml
index a9d80eaeeeb6..90d273b9fdd7 100644
--- a/Documentation/devicetree/bindings/media/amphion,vpu.yaml
+++ b/Documentation/devicetree/bindings/media/amphion,vpu.yaml
@@ -47,7 +47,7 @@ patternProperties:
$ref: ../mailbox/fsl,mu.yaml#
- "^vpu_core@[0-9a-f]+$":
+ "^vpu-core@[0-9a-f]+$":
description:
Each core correspond a decoder or encoder, need to configure them
separately. NXP i.MX8QM SoC has one decoder and two encoder, i.MX8QXP SoC
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] dt-bindings: lpspi: Add power-domains
2023-07-21 11:10 [PATCH 1/3] dt-bindings: media: amphion: Fix subnode pattern Alexander Stein
@ 2023-07-21 11:10 ` Alexander Stein
2023-07-21 11:21 ` Mark Brown
2023-07-21 11:10 ` [PATCH 3/3] dt-bindings: media: imx-jpeg: Add clocks property Alexander Stein
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Alexander Stein @ 2023-07-21 11:10 UTC (permalink / raw)
To: Rob Herring, Ming Qian, Shijie Qin, Zhou Peng,
Mauro Carvalho Chehab, Krzysztof Kozlowski, Conor Dooley,
Mirela Rabulea, Shawn Guo, Sascha Hauer, Fabio Estevam,
Mark Brown, Anson Huang
Cc: Alexander Stein, NXP Linux Team, Pengutronix Kernel Team,
linux-media, devicetree, linux-arm-kernel, linux-spi
i.MX8(X) based SoC use a power domain. Allow supplying this domain in
bindings.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
index e91425012319..727c5346b8ce 100644
--- a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
@@ -63,6 +63,9 @@ properties:
maximum: 2
default: 1
+ power-domains:
+ maxItems: 1
+
required:
- compatible
- reg
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] dt-bindings: media: imx-jpeg: Add clocks property
2023-07-21 11:10 [PATCH 1/3] dt-bindings: media: amphion: Fix subnode pattern Alexander Stein
2023-07-21 11:10 ` [PATCH 2/3] dt-bindings: lpspi: Add power-domains Alexander Stein
@ 2023-07-21 11:10 ` Alexander Stein
2023-07-21 12:50 ` [PATCH 1/3] dt-bindings: media: amphion: Fix subnode pattern Rob Herring
2023-07-22 10:23 ` Conor Dooley
3 siblings, 0 replies; 6+ messages in thread
From: Alexander Stein @ 2023-07-21 11:10 UTC (permalink / raw)
To: Rob Herring, Ming Qian, Shijie Qin, Zhou Peng,
Mauro Carvalho Chehab, Krzysztof Kozlowski, Conor Dooley,
Mirela Rabulea, Shawn Guo, Sascha Hauer, Fabio Estevam,
Mark Brown, Anson Huang
Cc: Alexander Stein, NXP Linux Team, Pengutronix Kernel Team,
linux-media, devicetree, linux-arm-kernel, linux-spi
i.MX8 and i.MX8X both use two clocks for accessing the periphery.
Add clocks and clock-names properties accordingly.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
.../devicetree/bindings/media/nxp,imx8-jpeg.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
index 3d9d1db37040..2533e16720f2 100644
--- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
+++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
@@ -46,6 +46,14 @@ properties:
minItems: 2 # Wrapper and 1 slot
maxItems: 5 # Wrapper and 4 slots
+ clocks:
+ maxItems: 2
+
+ clock-names:
+ items:
+ - const: per
+ - const: ipg
+
required:
- compatible
- reg
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] dt-bindings: lpspi: Add power-domains
2023-07-21 11:10 ` [PATCH 2/3] dt-bindings: lpspi: Add power-domains Alexander Stein
@ 2023-07-21 11:21 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2023-07-21 11:21 UTC (permalink / raw)
To: Alexander Stein
Cc: Rob Herring, Ming Qian, Shijie Qin, Zhou Peng,
Mauro Carvalho Chehab, Krzysztof Kozlowski, Conor Dooley,
Mirela Rabulea, Shawn Guo, Sascha Hauer, Fabio Estevam,
Anson Huang, NXP Linux Team, Pengutronix Kernel Team, linux-media,
devicetree, linux-arm-kernel, linux-spi
[-- Attachment #1.1: Type: text/plain, Size: 480 bytes --]
On Fri, Jul 21, 2023 at 01:10:19PM +0200, Alexander Stein wrote:
> i.MX8(X) based SoC use a power domain. Allow supplying this domain in
> bindings.
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] dt-bindings: media: amphion: Fix subnode pattern
2023-07-21 11:10 [PATCH 1/3] dt-bindings: media: amphion: Fix subnode pattern Alexander Stein
2023-07-21 11:10 ` [PATCH 2/3] dt-bindings: lpspi: Add power-domains Alexander Stein
2023-07-21 11:10 ` [PATCH 3/3] dt-bindings: media: imx-jpeg: Add clocks property Alexander Stein
@ 2023-07-21 12:50 ` Rob Herring
2023-07-22 10:23 ` Conor Dooley
3 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2023-07-21 12:50 UTC (permalink / raw)
To: Alexander Stein
Cc: Mauro Carvalho Chehab, Mirela Rabulea, linux-arm-kernel,
Mark Brown, NXP Linux Team, Pengutronix Kernel Team, Sascha Hauer,
Ming Qian, Conor Dooley, linux-media, Rob Herring, Fabio Estevam,
Shawn Guo, Anson Huang, linux-spi, Krzysztof Kozlowski,
Shijie Qin, devicetree, Zhou Peng
On Fri, 21 Jul 2023 13:10:18 +0200, Alexander Stein wrote:
> DT nodes use dashes instead of underscore. Adjust pattern to also fix
> warnings regarding nodes in arch/arm64/boot/dts/freescale/imx8-ss-vpu.dtsi
>
> Fixes: 38ad8b32f3af ("dt-bindings: media: amphion: add amphion video codec bindings")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Documentation/devicetree/bindings/media/amphion,vpu.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/amphion,vpu.example.dtb: vpu@2c000000: 'vpu_core@2d080000', 'vpu_core@2d090000', 'vpu_core@2d0a0000' do not match any of the regexes: '^mailbox@[0-9a-f]+$', '^vpu-core@[0-9a-f]+$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/media/amphion,vpu.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230721111020.1234278-1-alexander.stein@ew.tq-group.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] dt-bindings: media: amphion: Fix subnode pattern
2023-07-21 11:10 [PATCH 1/3] dt-bindings: media: amphion: Fix subnode pattern Alexander Stein
` (2 preceding siblings ...)
2023-07-21 12:50 ` [PATCH 1/3] dt-bindings: media: amphion: Fix subnode pattern Rob Herring
@ 2023-07-22 10:23 ` Conor Dooley
3 siblings, 0 replies; 6+ messages in thread
From: Conor Dooley @ 2023-07-22 10:23 UTC (permalink / raw)
To: Alexander Stein
Cc: Rob Herring, Ming Qian, Shijie Qin, Zhou Peng,
Mauro Carvalho Chehab, Krzysztof Kozlowski, Conor Dooley,
Mirela Rabulea, Shawn Guo, Sascha Hauer, Fabio Estevam,
Mark Brown, Anson Huang, NXP Linux Team, Pengutronix Kernel Team,
linux-media, devicetree, linux-arm-kernel, linux-spi
[-- Attachment #1.1: Type: text/plain, Size: 1233 bytes --]
On Fri, Jul 21, 2023 at 01:10:18PM +0200, Alexander Stein wrote:
> DT nodes use dashes instead of underscore. Adjust pattern to also fix
> warnings regarding nodes in arch/arm64/boot/dts/freescale/imx8-ss-vpu.dtsi
>
> Fixes: 38ad8b32f3af ("dt-bindings: media: amphion: add amphion video codec bindings")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Documentation/devicetree/bindings/media/amphion,vpu.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/amphion,vpu.yaml b/Documentation/devicetree/bindings/media/amphion,vpu.yaml
> index a9d80eaeeeb6..90d273b9fdd7 100644
> --- a/Documentation/devicetree/bindings/media/amphion,vpu.yaml
> +++ b/Documentation/devicetree/bindings/media/amphion,vpu.yaml
> @@ -47,7 +47,7 @@ patternProperties:
> $ref: ../mailbox/fsl,mu.yaml#
>
>
> - "^vpu_core@[0-9a-f]+$":
> + "^vpu-core@[0-9a-f]+$":
> description:
> Each core correspond a decoder or encoder, need to configure them
> separately. NXP i.MX8QM SoC has one decoder and two encoder, i.MX8QXP SoC
Per the bot, you have some examples you need to update as a result.
Thanks,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-22 10:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-21 11:10 [PATCH 1/3] dt-bindings: media: amphion: Fix subnode pattern Alexander Stein
2023-07-21 11:10 ` [PATCH 2/3] dt-bindings: lpspi: Add power-domains Alexander Stein
2023-07-21 11:21 ` Mark Brown
2023-07-21 11:10 ` [PATCH 3/3] dt-bindings: media: imx-jpeg: Add clocks property Alexander Stein
2023-07-21 12:50 ` [PATCH 1/3] dt-bindings: media: amphion: Fix subnode pattern Rob Herring
2023-07-22 10:23 ` Conor Dooley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox