From: Andi Shyti <andi.shyti@kernel.org>
To: carlos.song@nxp.com
Cc: aisheng.dong@nxp.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, xiaoning.wang@nxp.com, haibo.chen@nxp.com,
linux-imx@nxp.com, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] i2c: imx-lpi2c: directly return ISR when detect a NACK
Date: Thu, 27 Jul 2023 10:38:49 +0200 [thread overview]
Message-ID: <20230727083849.qcsmgqds3wyre72t@intel.intel> (raw)
In-Reply-To: <20230727030347.3552992-1-carlos.song@nxp.com>
Hi Carlos,
On Thu, Jul 27, 2023 at 11:03:47AM +0800, carlos.song@nxp.com wrote:
> From: Carlos Song <carlos.song@nxp.com>
>
> A NACK flag in ISR means i2c bus error. In such condition,
> there is no need to do read/write operation.
>
> In this patch, i2c will check MSR_NDF, MSR_RDF and MSR_TDF
> flag in turn, it's making mutually exclusive NACK/read/write.
> So when a NACK is received(MSR_NDF), i2c will return ISR
> directly and then stop i2c transfer.
>
> Signed-off-by: Carlos Song <carlos.song@nxp.com>
thanks!
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Andi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-27 8:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 3:03 [PATCH v4] i2c: imx-lpi2c: directly return ISR when detect a NACK carlos.song
2023-07-27 8:38 ` Andi Shyti [this message]
2023-08-02 20:10 ` Andi Shyti
2023-08-14 15:02 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230727083849.qcsmgqds3wyre72t@intel.intel \
--to=andi.shyti@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=carlos.song@nxp.com \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox