From: Andi Shyti <andi.shyti@kernel.org>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] i2c: s3c2410: Remove unused extern declarations
Date: Sun, 6 Aug 2023 00:13:39 +0200 [thread overview]
Message-ID: <20230805221339.7vl3jcutustlvhgc@intel.intel> (raw)
In-Reply-To: <20230728132318.25072-1-yuehaibing@huawei.com>
Hi Yue,
On Fri, Jul 28, 2023 at 09:23:18PM +0800, Yue Haibing wrote:
> commit 0d297df03890 ("ARM: s3c: simplify platform code") left behind
> s3c_i2c(*)_set_platdata().
> commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
> leave s5p_i2c_hdmiphy_set_platdata() declaration.
> And commit bad1e6aadd17 ("ARM: SAMSUNG: Cleanup plat-samsung/devs.c and devs.h")
> leave s3c_i2c(*)_cfg_gpio() alone.
I don't understand anything from the commit message here.
How about:
"
After some cleanups[*] certain s3c_i2c(*)_cfg_gpio() prototypes
have become unused. Remove them.
[*] 0d297df03890 ("ARM: s3c: simplify platform code")
d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
bad1e6aadd17 ("ARM: SAMSUNG: Cleanup plat-samsung/devs.c and devs.h")
"
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
which branch should this go? Samsung or i2c?
Andi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-08-05 22:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 13:23 [PATCH -next] i2c: s3c2410: Remove unused extern declarations Yue Haibing
2023-08-05 22:13 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230805221339.7vl3jcutustlvhgc@intel.intel \
--to=andi.shyti@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox