* Re: [PATCH v7 1/3] dt-bindings: arm: fsl: Add VAR-SOM-MX6 SoM with Custom Board
2023-08-07 16:03 ` [PATCH v7 1/3] dt-bindings: arm: fsl: Add VAR-SOM-MX6 SoM with Custom Board James Hilliard
@ 2023-08-08 7:45 ` Conor Dooley
0 siblings, 0 replies; 2+ messages in thread
From: Conor Dooley @ 2023-08-08 7:45 UTC (permalink / raw)
To: James Hilliard
Cc: devicetree, Pierluigi Passaro, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Marek Vasut, Frieder Schrempf,
Stefan Wahren, Michal Vokáč, Philippe Schenker,
Marcel Ziswiler, Christoph Niedermaier, Li Yang, linux-kernel,
linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 2027 bytes --]
On Mon, Aug 07, 2023 at 10:03:45AM -0600, James Hilliard wrote:
> On Wed, Jul 26, 2023 at 12:26 PM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Wed, Jul 26, 2023 at 06:37:39AM -0600, James Hilliard wrote:
> > > Add support for Variscite i.MX6Q VAR-SOM-MX6 SoM with Custom Board.
> > >
> > > Cc: Pierluigi Passaro <pierluigi.p@variscite.com>
> > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > > ---
> > > Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > index 2510eaa8906d..76bb098605e7 100644
> > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > @@ -385,6 +385,12 @@ properties:
> > > - const: toradex,apalis_imx6q
> > > - const: fsl,imx6q
> > >
> > > + - description: i.MX6Q Variscite VAR-SOM-MX6 Boards
> > > + items:
> > > + - const: variscite,mx6customboard
> > > + - const: variscite,var-som-imx6q
> > > + - const: fsl,imx6q
> >
> > I find it hard to tell what the sort order here is meant to be, but it
> > appears to be first by what I.MX processor and then by the board
> > compatibles? If so, this is added out of order.
>
> Ordering follows the same pattern as say the "Variscite VAR-SOM-MX8MM
> based boards", should it be different?
What I meant was I was not sure whether things were being sorted by the
contents of the description or by the compatible strings. I don't really
care which it is, I was hoping for an fsl platform maintainer to weigh
in.
If I hadn't already given one,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
for whatever way is opted for.
> > > - description: TQ-Systems TQMa6Q SoM (variant A) on MBa6x
> > > items:
> > > - const: tq,imx6q-mba6x-a
> > > --
> > > 2.34.1
> > >
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread