From: Bjorn Helgaas <helgaas@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI: mvebu: Mark driver as BROKEN
Date: Tue, 8 Aug 2023 11:26:27 -0500 [thread overview]
Message-ID: <20230808162627.GA314706@bhelgaas> (raw)
In-Reply-To: <20230808072605.n3rjfsxuogza7qth@pali>
[+cc linux-arm-kernel, beginning of thread:
https://lore.kernel.org/r/20230114164125.1298-1-pali@kernel.org]
On Tue, Aug 08, 2023 at 09:26:05AM +0200, Pali Rohár wrote:
> On Friday 04 August 2023 12:35:13 Russell King (Oracle) wrote:
> ...
> > For example, I have an Atheros PCIe WiFi card in an Armada 388 Clearfog
> > platform, and this works fine.
> >
> > Uwe has a SATA controller for a bunch of disks in an Armada 370 based
> > NAS platform that is connected to PCIe, and removing PCIe support
> > effectively makes his platform utterly useless.
> >
> > Please revert this patch.
>
> Please do not revert it, instead start fixing problems.
We know that like all the other drivers, the mvebu driver isn't
perfect. But I don't think effectively removing the driver completely
helps anybody. If people try to use it and notice problems, we have a
chance to try to fix them.
Or maybe I'm missing your point. I think you're suggesting that we
keep pci-mvebu in the tree but unselectable because it depends on
CONFIG_BROKEN. What would be the advantage of doing that?
Bjorn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next parent reply other threads:[~2023-08-08 16:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230808072605.n3rjfsxuogza7qth@pali>
2023-08-08 16:26 ` Bjorn Helgaas [this message]
2023-08-08 19:20 ` [PATCH] PCI: mvebu: Mark driver as BROKEN Pali Rohár
2023-08-08 19:54 ` Russell King (Oracle)
[not found] <20230114164125.1298-1-pali@kernel.org>
[not found] ` <ZMzicVQEyHyZzBOc@shell.armlinux.org.uk>
2023-08-04 13:46 ` Uwe Kleine-König
2023-08-04 17:00 ` Uwe Kleine-König
2023-08-08 7:27 ` Pali Rohár
2023-08-08 7:38 ` Uwe Kleine-König
2023-08-08 7:56 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230808162627.GA314706@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lpieralisi@kernel.org \
--cc=pali@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox